From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbcF0Mzo (ORCPT ); Mon, 27 Jun 2016 08:55:44 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37595 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcF0Mzm (ORCPT ); Mon, 27 Jun 2016 08:55:42 -0400 Date: Mon, 27 Jun 2016 14:55:24 +0200 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Jonathan Woithe Cc: Darren Hart , Jan-Marek Glogowski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fujitsu-laptop: Support touchpad toggle hotkey on Skylake-based models Message-ID: <20160627125524.GA2432@eudyptula.hq.kempniu.pl> References: <20160625091522.GA6423@eudyptula.hq.kempniu.pl> <1466926895-7830-1-git-send-email-kernel@kempniu.pl> <20160627124821.GB1544@marvin.atrad.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160627124821.GB1544@marvin.atrad.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Haswell-based Fujitsu laptops (Lifebook E734/E744/E754) have a touchpad > > toggle hotkey (Fn+F4) which is handled transparently to the operating > > system: while an ACPI notification is sent to FUJ02B1 when Fn+F4 is > > pressed, touchpad state is properly toggled without any explicit support > > for this operation in fujitsu-laptop. > > : > > I am happy with the patch code once the one-line fix from Jan-Marek is > included. However, given the rather non-intuitive behaviour that the patch > is dealing with I wonder whether a short (2 line) comment in the code might > be justified. There is otherwise no obvious reason why the touchpad button > code must interact with the rf kill hardware. > > Please respin the patch with the above in mind (and inlude Jan-Marek's fix). Will do, thanks for the review. -- Best regards, Michał Kępień