All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device
Date: Mon, 27 Jun 2016 14:13:04 -0700	[thread overview]
Message-ID: <20160627141304.2178a549@xeon-e3> (raw)
In-Reply-To: <1467052465-14488-4-git-send-email-dsa@cumulusnetworks.com>

On Mon, 27 Jun 2016 11:34:25 -0700
David Ahern <dsa@cumulusnetworks.com> wrote:

> +		case SSF_DEVCOND:
> +	{
> +		struct aafilter *a = (void *)f->pred;

I don't like the wandering bracket left, but all the code has that.
After this will change it to:
		case SSF_DEVCOND:  {
			struct aafilter *a = f->pred;
...

  reply	other threads:[~2016-06-27 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 18:34 [PATCH v2 iproute2 0/3] ss: Add support to filter by device David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 1/3] ss: Refactor inet_show_sock David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 2/3] ss: Allow ssfilter_bytecompile to return 0 David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 3/3] ss: Add support to filter on device David Ahern
2016-06-27 21:13   ` Stephen Hemminger [this message]
2016-06-28 17:40     ` David Ahern
2016-06-29  0:11       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160627141304.2178a549@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.