From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] e1000/base: Add missing braces to the
	'if'	statements
Date: Mon, 27 Jun 2016 16:05:55 +0100
Message-ID: <20160627150555.GC17808@bricha3-MOBL3>
References: <20160623092552.30932-1-mchandras@suse.de>
 <6A0DE07E22DDAD4C9103DF62FEBC09090348A2A5@shsmsx102.ccr.corp.intel.com>
 <2260730.VRpmIevhvb@xps13>
 <6A0DE07E22DDAD4C9103DF62FEBC09090348A53B@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>, Markos Chandras <mchandras@suse.de>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 40EF84CE4
 for <dev@dpdk.org>; Mon, 27 Jun 2016 17:06:00 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090348A53B@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 24, 2016 at 08:31:05AM +0000, Lu, Wenzhuo wrote:
> Hi Thomas, Markos,
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Friday, June 24, 2016 3:13 PM
> > To: Lu, Wenzhuo
> > Cc: dev@dpdk.org; Markos Chandras
> > Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if'
> > statements
> > 
> > 2016-06-24 00:43, Lu, Wenzhuo:
> > > Thanks for this patch. But normally the code in the base directory is synced
> > from the kernel driver. So we don't change it if there's no critical issue. It's easy
> > for us to maintain it. Thanks.
> > 
> > I think a build error is critical enough.
> OK. The change itself looks fine to me.

Applied to dpdk-next-net/rel_16_07

/Bruce