All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org,
	khilman@baylibre.com, carlo@caione.org
Cc: b.galvani@gmail.com, max.oss.09@gmail.com, marcel@ziswiler.com,
	linux@armlinux.org.uk, galak@codeaurora.org,
	ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
	pawel.moll@arm.com, robh+dt@kernel.org, linux@roeck-us.net,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, Stefan Agner <stefan@agner.ch>
Subject: [PATCH v4 4/5] mfd: rn5t618: register power off callback optionally
Date: Mon, 27 Jun 2016 23:27:56 -0700	[thread overview]
Message-ID: <20160628062757.24490-5-stefan@agner.ch> (raw)
In-Reply-To: <20160628062757.24490-1-stefan@agner.ch>

Only register power off if the PMIC is defined as system power
controller (see Documentation/devicetree/bindings/power/
power-controller.txt).

Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
 drivers/mfd/rn5t618.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index c86160d..1831740 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -102,9 +102,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
-	if (!pm_power_off) {
-		rn5t618_pm_power_off = priv;
-		pm_power_off = rn5t618_power_off;
+	if (of_device_is_system_power_controller(i2c->dev.of_node)) {
+		if (!pm_power_off) {
+			rn5t618_pm_power_off = priv;
+			pm_power_off = rn5t618_power_off;
+		} else {
+			dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
+		}
 	}
 
 	return 0;
-- 
2.8.3

WARNING: multiple messages have this Message-ID
From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/5] mfd: rn5t618: register power off callback optionally
Date: Mon, 27 Jun 2016 23:27:56 -0700	[thread overview]
Message-ID: <20160628062757.24490-5-stefan@agner.ch> (raw)
In-Reply-To: <20160628062757.24490-1-stefan@agner.ch>

Only register power off if the PMIC is defined as system power
controller (see Documentation/devicetree/bindings/power/
power-controller.txt).

Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
 drivers/mfd/rn5t618.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index c86160d..1831740 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -102,9 +102,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
-	if (!pm_power_off) {
-		rn5t618_pm_power_off = priv;
-		pm_power_off = rn5t618_power_off;
+	if (of_device_is_system_power_controller(i2c->dev.of_node)) {
+		if (!pm_power_off) {
+			rn5t618_pm_power_off = priv;
+			pm_power_off = rn5t618_power_off;
+		} else {
+			dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
+		}
 	}
 
 	return 0;
-- 
2.8.3

WARNING: multiple messages have this Message-ID
From: stefan@agner.ch (Stefan Agner)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 4/5] mfd: rn5t618: register power off callback optionally
Date: Mon, 27 Jun 2016 23:27:56 -0700	[thread overview]
Message-ID: <20160628062757.24490-5-stefan@agner.ch> (raw)
In-Reply-To: <20160628062757.24490-1-stefan@agner.ch>

Only register power off if the PMIC is defined as system power
controller (see Documentation/devicetree/bindings/power/
power-controller.txt).

Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
 drivers/mfd/rn5t618.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
index c86160d..1831740 100644
--- a/drivers/mfd/rn5t618.c
+++ b/drivers/mfd/rn5t618.c
@@ -102,9 +102,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
-	if (!pm_power_off) {
-		rn5t618_pm_power_off = priv;
-		pm_power_off = rn5t618_power_off;
+	if (of_device_is_system_power_controller(i2c->dev.of_node)) {
+		if (!pm_power_off) {
+			rn5t618_pm_power_off = priv;
+			pm_power_off = rn5t618_power_off;
+		} else {
+			dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
+		}
 	}
 
 	return 0;
-- 
2.8.3

  parent reply	other threads:[~2016-06-28  6:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  6:27 [PATCH v4 0/5] regulator: add Ricoh RN5T567 PMIC support Stefan Agner
2016-06-28  6:27 ` Stefan Agner
2016-06-28  6:27 ` Stefan Agner
2016-06-28  6:27 ` Stefan Agner
2016-06-28  6:27 ` [PATCH v4 1/5] ARM: dts: meson: minix-neo-x8: define PMIC as power controller Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27 ` [PATCH v4 2/5] mfd: add Ricoh RN5T567 PMIC support Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28 12:00   ` Lee Jones
2016-06-28 12:00     ` Lee Jones
2016-06-28 12:00     ` Lee Jones
2016-06-28  6:27 ` [PATCH v4 3/5] regulator: rn5t618: add " Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27 ` Stefan Agner [this message]
2016-06-28  6:27   ` [PATCH v4 4/5] mfd: rn5t618: register power off callback optionally Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28 12:01   ` Lee Jones
2016-06-28 12:01     ` Lee Jones
2016-06-28 12:01     ` Lee Jones
2016-06-28  6:27 ` [PATCH v4 5/5] mfd: rn5t618: register restart handler Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28  6:27   ` Stefan Agner
2016-06-28 12:03   ` Lee Jones
2016-06-28 12:03     ` Lee Jones
2016-06-28 12:03     ` Lee Jones
2016-06-28 12:03     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628062757.24490-5-stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=b.galvani@gmail.com \
    --cc=broonie@kernel.org \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=khilman@baylibre.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=marcel@ziswiler.com \
    --cc=mark.rutland@arm.com \
    --cc=max.oss.09@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.