From: Herbert Xu <herbert@gondor.apana.org.au>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues
Date: Tue, 28 Jun 2016 16:37:34 +0800 [thread overview]
Message-ID: <20160628083734.GC15985@gondor.apana.org.au> (raw)
In-Reply-To: <1467098587-1038-1-git-send-email-k.kozlowski@samsung.com>
On Tue, Jun 28, 2016 at 09:23:06AM +0200, Krzysztof Kozlowski wrote:
> The recently added test_mb_ahash_speed() has clearly serious coding
> style issues. Try to fix some of them:
> 1. Don't mix pr_err() and printk();
> 2. Don't wrap strings;
> 3. Properly align goto statement in if() block;
> 4. Align wrapped arguments on new line;
> 5. Don't wrap functions on first argument;
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-06-28 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 7:23 [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues Krzysztof Kozlowski
2016-06-28 7:23 ` [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Krzysztof Kozlowski
2016-06-28 8:41 ` Herbert Xu
2016-06-28 8:49 ` Krzysztof Kozlowski
2016-06-28 9:55 ` crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Herbert Xu
2016-06-28 10:15 ` Krzysztof Kozlowski
2016-06-28 12:33 ` [PATCH v2] " Herbert Xu
2016-06-29 8:16 ` Krzysztof Kozlowski
2016-06-29 8:19 ` Herbert Xu
2016-06-29 8:28 ` Krzysztof Kozlowski
2016-06-29 17:45 ` Megha Dey
2016-06-30 3:00 ` crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash test Herbert Xu
2016-06-30 17:36 ` Megha Dey
2016-06-28 8:37 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628083734.GC15985@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=k.kozlowski@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.