From: Herbert Xu <herbert@gondor.apana.org.au>
To: George Spelvin <linux@sciencehorizons.net>
Cc: linux-bluetooth@vger.kernel.org, linux-crypto@vger.kernel.org,
luto@amacapital.net, netdev@vger.kernel.org
Subject: Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)
Date: Tue, 28 Jun 2016 21:30:50 +0800 [thread overview]
Message-ID: <20160628133050.GA18468@gondor.apana.org.au> (raw)
In-Reply-To: <20160628132301.11479.qmail@ns.sciencehorizons.net>
On Tue, Jun 28, 2016 at 09:23:01AM -0400, George Spelvin wrote:
>
> Wow, I should see how you do that. I couldn't get it below 3
> blocks of temporary, and the dst SG list only gives you
> one and a half.
I don't mean that I'm using no temporary buffers at all, just
that the actual crypto only operates on the SG lists. I'm still
doing the xoring and stitching in temp buffers. I just counted
and I'm using three blocks like you.
> Is net/sunrpc/auth_gss/gss_krb5_mech.c doing something odd?
Yes gss_krb5_crypto.c is the one.
> I have a request of you: like Andy, I find the crypto layer an
> impenetrable thicket of wrapper structures. I'm not suggesting there
> aren't reasons for it, but it's extremely hard to infer those reasons by
> looking at the code. If I were to draft a (hilariously wrong) overview
> document, would you be willing to edit it into correctness?
We have actually gained quite a bit of documentation recently.
Have you looked at Documentation/DocBook/crypto-API.tmpl?
More is always welcome of course.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-06-28 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 12:37 Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc) George Spelvin
2016-06-28 12:37 ` George Spelvin
2016-06-28 12:42 ` Herbert Xu
2016-06-28 13:23 ` George Spelvin
2016-06-28 13:30 ` Herbert Xu [this message]
2016-06-28 14:32 ` George Spelvin
2016-06-29 2:20 ` Herbert Xu
[not found] ` <20160629022049.GA23390-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2016-06-29 12:10 ` George Spelvin
2016-06-29 12:10 ` George Spelvin
-- strict thread matches above, loose matches on Subject: below --
2016-06-21 17:43 Andy Lutomirski
[not found] ` <CALCETrVJzzKkRsSbgsUmVd_+ArKEgoRSVdG1tVp7CXzFoPyVgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-22 0:42 ` Herbert Xu
2016-06-22 0:42 ` Herbert Xu
2016-06-22 0:52 ` Andy Lutomirski
2016-06-22 21:48 ` Andy Lutomirski
2016-06-22 23:45 ` Andy Lutomirski
2016-06-23 3:48 ` Herbert Xu
2016-06-23 6:41 ` Herbert Xu
2016-06-23 22:11 ` Andy Lutomirski
[not found] ` <CALCETrUWyNz91WO6O3dNb+YELeZy5q4+oTo6dLRR67P2WvBB8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-23 3:37 ` Herbert Xu
2016-06-23 3:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628133050.GA18468@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.