From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752395AbcF1Ue4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 16:34:56 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:36454 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751673AbcF1Uey (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 16:34:54 -0400
Date: Tue, 28 Jun 2016 22:40:43 +0200
From: Emese Revfy <re.emese@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu,
        spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org,
        linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com,
        linux-kbuild@vger.kernel.org, minipli@ld-linux.so,
        linux@armlinux.org.uk, catalin.marinas@arm.com,
        linux@rasmusvillemoes.dk, david.brown@linaro.org,
        benh@kernel.crashing.org, tglx@linutronix.de,
        akpm@linux-foundation.org, jlayton@poochiereds.net, arnd@arndb.de
Subject: Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute
Message-Id: <20160628224043.c543b2b01e776e7757bbb3f4@gmail.com>
In-Reply-To: <1467132211.24287.31.camel@perches.com>
References: <20160628133407.10c2ea1ecd194e8085e84c5a@gmail.com>
	<20160628133645.8f3cac0df4fc363e308426ac@gmail.com>
	<1467132211.24287.31.camel@perches.com>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Jun 2016 09:43:31 -0700
Joe Perches <joe@perches.com> wrote:

> On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote:
> > The nocapture gcc attribute can be on functions only.
> > The attribute takes one or more unsigned integer constants as parameters
> > that specify the function argument(s) of const char* type to initify.
> 
> Perhaps this should be const <type>*

For me function arguments are the values passed to a function call so
the const char* type is good because this is the only one that the plugin handles
(for now at least).

-- 
Emese

From mboxrd@z Thu Jan  1 00:00:00 1970
Reply-To: kernel-hardening@lists.openwall.com
Date: Tue, 28 Jun 2016 22:40:43 +0200
From: Emese Revfy <re.emese@gmail.com>
Message-Id: <20160628224043.c543b2b01e776e7757bbb3f4@gmail.com>
In-Reply-To: <1467132211.24287.31.camel@perches.com>
References: <20160628133407.10c2ea1ecd194e8085e84c5a@gmail.com>
	<20160628133645.8f3cac0df4fc363e308426ac@gmail.com>
	<1467132211.24287.31.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [kernel-hardening] Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute
To: Joe Perches <joe@perches.com>
Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu, spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, linux-kbuild@vger.kernel.org, minipli@ld-linux.so, linux@armlinux.org.uk, catalin.marinas@arm.com, linux@rasmusvillemoes.dk, david.brown@linaro.org, benh@kernel.crashing.org, tglx@linutronix.de, akpm@linux-foundation.org, jlayton@poochiereds.net, arnd@arndb.de
List-ID: <kernel-hardening.lists.openwall.com>

On Tue, 28 Jun 2016 09:43:31 -0700
Joe Perches <joe@perches.com> wrote:

> On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote:
> > The nocapture gcc attribute can be on functions only.
> > The attribute takes one or more unsigned integer constants as parameters
> > that specify the function argument(s) of const char* type to initify.
> 
> Perhaps this should be const <type>*

For me function arguments are the values passed to a function call so
the const char* type is good because this is the only one that the plugin handles
(for now at least).

-- 
Emese