From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbcF2Stu (ORCPT ); Wed, 29 Jun 2016 14:49:50 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34956 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbcF2Sts (ORCPT ); Wed, 29 Jun 2016 14:49:48 -0400 Date: Wed, 29 Jun 2016 20:42:04 +0200 From: Emese Revfy To: Joe Perches Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu, spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, linux-kbuild@vger.kernel.org, minipli@ld-linux.so, linux@armlinux.org.uk, catalin.marinas@arm.com, linux@rasmusvillemoes.dk, david.brown@linaro.org, benh@kernel.crashing.org, tglx@linutronix.de, akpm@linux-foundation.org, jlayton@poochiereds.net, arnd@arndb.de Subject: Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute Message-Id: <20160629204204.859692ea2b7f570260ed18a0@gmail.com> In-Reply-To: <1467147657.24287.59.camel@perches.com> References: <20160628133407.10c2ea1ecd194e8085e84c5a@gmail.com> <20160628133645.8f3cac0df4fc363e308426ac@gmail.com> <1467132211.24287.31.camel@perches.com> <20160628224043.c543b2b01e776e7757bbb3f4@gmail.com> <1467147657.24287.59.camel@perches.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016 14:00:57 -0700 Joe Perches wrote: > On Tue, 2016-06-28 at 22:40 +0200, Emese Revfy wrote: > > On Tue, 28 Jun 2016 09:43:31 -0700 Joe Perches wrote: > > > On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote: > > > > The nocapture gcc attribute can be on functions only. > > > > The attribute takes one or more unsigned integer constants as parameters > > > > that specify the function argument(s) of const char* type to initify. > > > Perhaps this should be const * > > For me function arguments are the values passed to a function call so > > the const char* type is good because this is the only one that the plugin handles > > (for now at least). > > OK, but this function prototype specified takes a const void * > > +extern void * memcpy(void *, const void *, __kernel_size_t) __nocapture(2); What matters for the plugin is the type of the passed arguments (which can be const char* in the current implementation), not that of the parameters. -- Emese From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com Date: Wed, 29 Jun 2016 20:42:04 +0200 From: Emese Revfy Message-Id: <20160629204204.859692ea2b7f570260ed18a0@gmail.com> In-Reply-To: <1467147657.24287.59.camel@perches.com> References: <20160628133407.10c2ea1ecd194e8085e84c5a@gmail.com> <20160628133645.8f3cac0df4fc363e308426ac@gmail.com> <1467132211.24287.31.camel@perches.com> <20160628224043.c543b2b01e776e7757bbb3f4@gmail.com> <1467147657.24287.59.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [kernel-hardening] Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute To: Joe Perches Cc: kernel-hardening@lists.openwall.com, pageexec@freemail.hu, spender@grsecurity.net, mmarek@suse.com, keescook@chromium.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, linux-kbuild@vger.kernel.org, minipli@ld-linux.so, linux@armlinux.org.uk, catalin.marinas@arm.com, linux@rasmusvillemoes.dk, david.brown@linaro.org, benh@kernel.crashing.org, tglx@linutronix.de, akpm@linux-foundation.org, jlayton@poochiereds.net, arnd@arndb.de List-ID: On Tue, 28 Jun 2016 14:00:57 -0700 Joe Perches wrote: > On Tue, 2016-06-28 at 22:40 +0200, Emese Revfy wrote: > > On Tue, 28 Jun 2016 09:43:31 -0700 Joe Perches wrote: > > > On Tue, 2016-06-28 at 13:36 +0200, Emese Revfy wrote: > > > > The nocapture gcc attribute can be on functions only. > > > > The attribute takes one or more unsigned integer constants as parameters > > > > that specify the function argument(s) of const char* type to initify. > > > Perhaps this should be const * > > For me function arguments are the values passed to a function call so > > the const char* type is good because this is the only one that the plugin handles > > (for now at least). > > OK, but this function prototype specified takes a const void * > > +extern void * memcpy(void *, const void *, __kernel_size_t) __nocapture(2); What matters for the plugin is the type of the passed arguments (which can be const char* in the current implementation), not that of the parameters. -- Emese