From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH 13/21] usb: chipidea: msm: Allow core to get usb phy Date: Thu, 30 Jun 2016 09:43:10 +0800 Message-ID: <20160630014310.GD19928@shlinux2> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-14-stephen.boyd@linaro.org> <20160629064811.GH25236@shlinux2> <20160629113411.GO25236@shlinux2> <146722867837.16253.5338887948471498730@sboyd-linaro> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <146722867837.16253.5338887948471498730@sboyd-linaro> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stephen Boyd Cc: Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Peter Chen , Greg Kroah-Hartman , Andy Gross , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Wed, Jun 29, 2016 at 12:31:18PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-06-29 04:34:11) > > On Wed, Jun 29, 2016 at 02:48:11PM +0800, Peter Chen wrote: > > > On Sun, Jun 26, 2016 at 12:28:30AM -0700, Stephen Boyd wrote: > > > > @@ -53,21 +44,9 @@ static struct ci_hdrc_platform_data ci_hdrc_msm_platdata = { > > > > static int ci_hdrc_msm_probe(struct platform_device *pdev) > > > > { > > > > struct platform_device *plat_ci; > > > > - struct usb_phy *phy; > > > > > > > > dev_dbg(&pdev->dev, "ci_hdrc_msm_probe\n"); > > > > > > > > - /* > > > > - * OTG(PHY) driver takes care of PHY initialization, clock management, > > > > - * powering up VBUS, mapping of registers address space and power > > > > - * management. > > > > - */ > > > > - phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); > > > > - if (IS_ERR(phy)) > > > > - return PTR_ERR(phy); > > > > - > > > > - ci_hdrc_msm_platdata.usb_phy = phy; > > > > - > > > > plat_ci = ci_hdrc_add_device(&pdev->dev, > > > > pdev->resource, pdev->num_resources, > > > > &ci_hdrc_msm_platdata); > > > > -- > > > > > > > Wait, how about the UTMI PHY? You don't have a platform which needs > > to get PHY through the phandle? > > Sorry I don't understand the question. What is the UTMI PHY? We need to > get the phy through phandles. The only boards that are using ci_hdrc_msm > are DT enabled boards. UTMI PHY is the PHY inside the SoC, I just want to confirm all your PHYs are at ulpi bus, if they are, you can do that, else, you may need above way to get the PHY through PHY node. -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbcF3BvP (ORCPT ); Wed, 29 Jun 2016 21:51:15 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35419 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbcF3BvM (ORCPT ); Wed, 29 Jun 2016 21:51:12 -0400 Date: Thu, 30 Jun 2016 09:43:10 +0800 From: Peter Chen To: Stephen Boyd Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Subject: Re: [PATCH 13/21] usb: chipidea: msm: Allow core to get usb phy Message-ID: <20160630014310.GD19928@shlinux2> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-14-stephen.boyd@linaro.org> <20160629064811.GH25236@shlinux2> <20160629113411.GO25236@shlinux2> <146722867837.16253.5338887948471498730@sboyd-linaro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146722867837.16253.5338887948471498730@sboyd-linaro> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2016 at 12:31:18PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-06-29 04:34:11) > > On Wed, Jun 29, 2016 at 02:48:11PM +0800, Peter Chen wrote: > > > On Sun, Jun 26, 2016 at 12:28:30AM -0700, Stephen Boyd wrote: > > > > @@ -53,21 +44,9 @@ static struct ci_hdrc_platform_data ci_hdrc_msm_platdata = { > > > > static int ci_hdrc_msm_probe(struct platform_device *pdev) > > > > { > > > > struct platform_device *plat_ci; > > > > - struct usb_phy *phy; > > > > > > > > dev_dbg(&pdev->dev, "ci_hdrc_msm_probe\n"); > > > > > > > > - /* > > > > - * OTG(PHY) driver takes care of PHY initialization, clock management, > > > > - * powering up VBUS, mapping of registers address space and power > > > > - * management. > > > > - */ > > > > - phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); > > > > - if (IS_ERR(phy)) > > > > - return PTR_ERR(phy); > > > > - > > > > - ci_hdrc_msm_platdata.usb_phy = phy; > > > > - > > > > plat_ci = ci_hdrc_add_device(&pdev->dev, > > > > pdev->resource, pdev->num_resources, > > > > &ci_hdrc_msm_platdata); > > > > -- > > > > > > > Wait, how about the UTMI PHY? You don't have a platform which needs > > to get PHY through the phandle? > > Sorry I don't understand the question. What is the UTMI PHY? We need to > get the phy through phandles. The only boards that are using ci_hdrc_msm > are DT enabled boards. UTMI PHY is the PHY inside the SoC, I just want to confirm all your PHYs are at ulpi bus, if they are, you can do that, else, you may need above way to get the PHY through PHY node. -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: hzpeterchen@gmail.com (Peter Chen) Date: Thu, 30 Jun 2016 09:43:10 +0800 Subject: [PATCH 13/21] usb: chipidea: msm: Allow core to get usb phy In-Reply-To: <146722867837.16253.5338887948471498730@sboyd-linaro> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-14-stephen.boyd@linaro.org> <20160629064811.GH25236@shlinux2> <20160629113411.GO25236@shlinux2> <146722867837.16253.5338887948471498730@sboyd-linaro> Message-ID: <20160630014310.GD19928@shlinux2> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 29, 2016 at 12:31:18PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-06-29 04:34:11) > > On Wed, Jun 29, 2016 at 02:48:11PM +0800, Peter Chen wrote: > > > On Sun, Jun 26, 2016 at 12:28:30AM -0700, Stephen Boyd wrote: > > > > @@ -53,21 +44,9 @@ static struct ci_hdrc_platform_data ci_hdrc_msm_platdata = { > > > > static int ci_hdrc_msm_probe(struct platform_device *pdev) > > > > { > > > > struct platform_device *plat_ci; > > > > - struct usb_phy *phy; > > > > > > > > dev_dbg(&pdev->dev, "ci_hdrc_msm_probe\n"); > > > > > > > > - /* > > > > - * OTG(PHY) driver takes care of PHY initialization, clock management, > > > > - * powering up VBUS, mapping of registers address space and power > > > > - * management. > > > > - */ > > > > - phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); > > > > - if (IS_ERR(phy)) > > > > - return PTR_ERR(phy); > > > > - > > > > - ci_hdrc_msm_platdata.usb_phy = phy; > > > > - > > > > plat_ci = ci_hdrc_add_device(&pdev->dev, > > > > pdev->resource, pdev->num_resources, > > > > &ci_hdrc_msm_platdata); > > > > -- > > > > > > > Wait, how about the UTMI PHY? You don't have a platform which needs > > to get PHY through the phandle? > > Sorry I don't understand the question. What is the UTMI PHY? We need to > get the phy through phandles. The only boards that are using ci_hdrc_msm > are DT enabled boards. UTMI PHY is the PHY inside the SoC, I just want to confirm all your PHYs are at ulpi bus, if they are, you can do that, else, you may need above way to get the PHY through PHY node. -- Best Regards, Peter Chen