From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fam Zheng Subject: [PATCH v2 07/12] pktcdvd: Generate uevent after attribute available Date: Thu, 30 Jun 2016 09:59:48 +0800 Message-ID: <20160630015953.6888-8-famz@redhat.com> References: <20160630015953.6888-1-famz@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160630015953.6888-1-famz@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: linux-kernel@vger.kernel.org Cc: Sergey Senozhatsky , "Michael S. Tsirkin" , Benjamin Herrenschmidt , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Keith Busch , Paul Mackerras , Michael Ellerman , Christoph Hellwig , Shaohua Li , Nitin Gupta , famz@redhat.com, Jiri Kosina , linux-block@vger.kernel.org, "Ed L. Cashin" , Jens Axboe , linux-raid@vger.kernel.org, David Woodhouse , linux-mmc@vger.kernel.org, Minchan Kim , linux-mtd@lists.infradead.org, Brian Norris , linuxppc-dev@lists.ozlabs.org List-Id: linux-raid.ids It is documented that KOBJ_ADD should be generated after the object's attributes and children are ready. We can achieve this with the new disk_gen_uevents interface. Signed-off-by: Fam Zheng --- drivers/block/pktcdvd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 00928406..a4e6bb7 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2785,11 +2785,13 @@ static int pkt_setup_dev(dev_t dev, dev_t* pkt_dev) disk->events = pd->bdev->bd_disk->events; disk->async_events = pd->bdev->bd_disk->async_events; - add_disk(disk, true); + add_disk(disk, false); pkt_sysfs_dev_new(pd); pkt_debugfs_dev_new(pd); + disk_gen_uevents(disk); + pkt_devs[idx] = pd; if (pkt_dev) *pkt_dev = pd->pkt_dev; -- 2.9.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Fam Zheng To: linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jens Axboe , "Ed L. Cashin" , Jiri Kosina , "Michael S. Tsirkin" , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Shaohua Li , Ulf Hansson , David Woodhouse , Brian Norris , Keith Busch , linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, Christoph Hellwig , famz@redhat.com Subject: [PATCH v2 07/12] pktcdvd: Generate uevent after attribute available Date: Thu, 30 Jun 2016 09:59:48 +0800 Message-Id: <20160630015953.6888-8-famz@redhat.com> In-Reply-To: <20160630015953.6888-1-famz@redhat.com> References: <20160630015953.6888-1-famz@redhat.com> List-ID: It is documented that KOBJ_ADD should be generated after the object's attributes and children are ready. We can achieve this with the new disk_gen_uevents interface. Signed-off-by: Fam Zheng --- drivers/block/pktcdvd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 00928406..a4e6bb7 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2785,11 +2785,13 @@ static int pkt_setup_dev(dev_t dev, dev_t* pkt_dev) disk->events = pd->bdev->bd_disk->events; disk->async_events = pd->bdev->bd_disk->async_events; - add_disk(disk, true); + add_disk(disk, false); pkt_sysfs_dev_new(pd); pkt_debugfs_dev_new(pd); + disk_gen_uevents(disk); + pkt_devs[idx] = pd; if (pkt_dev) *pkt_dev = pd->pkt_dev; -- 2.9.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: famz@redhat.com (Fam Zheng) Date: Thu, 30 Jun 2016 09:59:48 +0800 Subject: [PATCH v2 07/12] pktcdvd: Generate uevent after attribute available In-Reply-To: <20160630015953.6888-1-famz@redhat.com> References: <20160630015953.6888-1-famz@redhat.com> Message-ID: <20160630015953.6888-8-famz@redhat.com> It is documented that KOBJ_ADD should be generated after the object's attributes and children are ready. We can achieve this with the new disk_gen_uevents interface. Signed-off-by: Fam Zheng --- drivers/block/pktcdvd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c index 00928406..a4e6bb7 100644 --- a/drivers/block/pktcdvd.c +++ b/drivers/block/pktcdvd.c @@ -2785,11 +2785,13 @@ static int pkt_setup_dev(dev_t dev, dev_t* pkt_dev) disk->events = pd->bdev->bd_disk->events; disk->async_events = pd->bdev->bd_disk->async_events; - add_disk(disk, true); + add_disk(disk, false); pkt_sysfs_dev_new(pd); pkt_debugfs_dev_new(pd); + disk_gen_uevents(disk); + pkt_devs[idx] = pd; if (pkt_dev) *pkt_dev = pd->pkt_dev; -- 2.9.0