From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbcF3Kdt (ORCPT ); Thu, 30 Jun 2016 06:33:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42063 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751757AbcF3Kdq (ORCPT ); Thu, 30 Jun 2016 06:33:46 -0400 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: naveen.n.rao@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 30 Jun 2016 16:02:54 +0530 From: "Naveen N. Rao" To: Denis Kirjanov Cc: Andreas Ziegler , linuxppc-dev@lists.ozlabs.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv2 0/7] eBPF JIT for PPC64 References: <5774E0FC.7010407@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16063010-0052-0000-0000-000001A906B5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16063010-0053-0000-0000-0000064A7569 Message-Id: <20160630103254.GD14508@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-30_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606300099 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/06/30 12:34PM, Denis Kirjanov wrote: > On 6/30/16, Andreas Ziegler wrote: > > Hi Naveen, > > > > this patchset makes a change to arch/powerpc/net/Makefile in order to only > > compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use > > bpf_jit_comp64.c if CONFIG_PPC64 is enabled. > > > > Inside arch/powerpc/net/bpf_jit_comp.c, however, there is still an #ifdef > > CONFIG_PPC64 block at line 667 (linux-next of today, i.e., next-20160630): > > > > #ifdef CONFIG_PPC64 > > /* Function descriptor nastiness: Address + TOC */ > > ((u64 *)image)[0] = (u64)code_base; > > ((u64 *)image)[1] = local_paca->kernel_toc; > > #endif > > > > From my understanding of the code, this #ifdef can now be removed, as there > > is > > no way the file could be compiled with CONFIG_PPC64 enabled. Is this > > correct? > > That was used for running classic BPF on ppc64. With eBPF on ppc64 the > whole block can be removed. Yes, that can be removed and so can the many 64-bit related macros in bpf_jit32.h. The reason I didn't remove those just yet was so that we could easily try out the classic BPF JIT for ppc64 BE, for testing/performance comparison and so on. I think it would be good to retain this for one kernel release. - Naveen