From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752556AbcF3O0D (ORCPT ); Thu, 30 Jun 2016 10:26:03 -0400 Received: from mail.fireflyinternet.com ([87.106.93.118]:56205 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752164AbcF3O0A (ORCPT ); Thu, 30 Jun 2016 10:26:00 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 30 Jun 2016 15:23:59 +0100 From: Chris Wilson To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 1/2] dma-buf/fence-array: add fence_is_array() Message-ID: <20160630142359.GC28577@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= References: <1467295788-6422-1-git-send-email-gustavo@padovan.org> <1467295788-6422-2-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467295788-6422-2-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 11:09:47AM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add helper to check if fence is array. > > Cc: Chris Wilson > Cc: Christian König > Signed-off-by: Gustavo Padovan > --- > include/linux/fence-array.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/fence-array.h b/include/linux/fence-array.h > index 86baaa4..d2e9f40 100644 > --- a/include/linux/fence-array.h > +++ b/include/linux/fence-array.h > @@ -52,6 +52,16 @@ struct fence_array { > extern const struct fence_ops fence_array_ops; > > /** > + * fence_is_array - check if a fence is from the array subsclass > + * > + * Return true if it is a fence_array and false otherwise. > + */ > +static inline bool fence_is_array(struct fence *fence) > +{ > + return (fence->ops == &fence_array_ops) ? true : false; Just return fence->ops == &fence_array_ops; It's a logical operation, it is already a boolean. With that, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] dma-buf/fence-array: add fence_is_array() Date: Thu, 30 Jun 2016 15:23:59 +0100 Message-ID: <20160630142359.GC28577@nuc-i3427.alporthouse.com> References: <1467295788-6422-1-git-send-email-gustavo@padovan.org> <1467295788-6422-2-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id D9DFD6E8B1 for ; Thu, 30 Jun 2016 14:26:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1467295788-6422-2-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, m.chehab@samsung.com, Gustavo Padovan , John Harrison , laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgMTE6MDk6NDdBTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9y YS5jby51az4KPiAKPiBBZGQgaGVscGVyIHRvIGNoZWNrIGlmIGZlbmNlIGlzIGFycmF5Lgo+IAo+ IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogQ2hyaXN0 aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEd1 c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiAtLS0KPiAg aW5jbHVkZS9saW51eC9mZW5jZS1hcnJheS5oIHwgMTAgKysrKysrKysrKwo+ICAxIGZpbGUgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2Zl bmNlLWFycmF5LmggYi9pbmNsdWRlL2xpbnV4L2ZlbmNlLWFycmF5LmgKPiBpbmRleCA4NmJhYWE0 Li5kMmU5ZjQwIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvZmVuY2UtYXJyYXkuaAo+ICsr KyBiL2luY2x1ZGUvbGludXgvZmVuY2UtYXJyYXkuaAo+IEBAIC01Miw2ICs1MiwxNiBAQCBzdHJ1 Y3QgZmVuY2VfYXJyYXkgewo+ICBleHRlcm4gY29uc3Qgc3RydWN0IGZlbmNlX29wcyBmZW5jZV9h cnJheV9vcHM7Cj4gIAo+ICAvKioKPiArICogZmVuY2VfaXNfYXJyYXkgLSBjaGVjayBpZiBhIGZl bmNlIGlzIGZyb20gdGhlIGFycmF5IHN1YnNjbGFzcwo+ICsgKgo+ICsgKiBSZXR1cm4gdHJ1ZSBp ZiBpdCBpcyBhIGZlbmNlX2FycmF5IGFuZCBmYWxzZSBvdGhlcndpc2UuCj4gKyAqLwo+ICtzdGF0 aWMgaW5saW5lIGJvb2wgZmVuY2VfaXNfYXJyYXkoc3RydWN0IGZlbmNlICpmZW5jZSkKPiArewo+ ICsJcmV0dXJuIChmZW5jZS0+b3BzID09ICZmZW5jZV9hcnJheV9vcHMpID8gdHJ1ZSA6IGZhbHNl OwoKSnVzdCByZXR1cm4gZmVuY2UtPm9wcyA9PSAmZmVuY2VfYXJyYXlfb3BzOyBJdCdzIGEgbG9n aWNhbCBvcGVyYXRpb24sIGl0CmlzIGFscmVhZHkgYSBib29sZWFuLiBXaXRoIHRoYXQsCgpSZXZp ZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Ci1DaHJpcwoK LS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50cmUKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==