From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752705AbcF3WKV (ORCPT ); Thu, 30 Jun 2016 18:10:21 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34440 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbcF3WKR (ORCPT ); Thu, 30 Jun 2016 18:10:17 -0400 Date: Thu, 30 Jun 2016 22:55:54 +0100 From: Chris Wilson To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 1/2] dma-buf/fence-array: add fence_is_array() Message-ID: <20160630215554.GA28931@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= References: <1467295788-6422-1-git-send-email-gustavo@padovan.org> <1467295788-6422-2-git-send-email-gustavo@padovan.org> <20160630142359.GC28577@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160630142359.GC28577@nuc-i3427.alporthouse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 03:23:59PM +0100, Chris Wilson wrote: > On Thu, Jun 30, 2016 at 11:09:47AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Add helper to check if fence is array. > > > > Cc: Chris Wilson > > Cc: Christian König > > Signed-off-by: Gustavo Padovan > > --- > > include/linux/fence-array.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/linux/fence-array.h b/include/linux/fence-array.h > > index 86baaa4..d2e9f40 100644 > > --- a/include/linux/fence-array.h > > +++ b/include/linux/fence-array.h > > @@ -52,6 +52,16 @@ struct fence_array { > > extern const struct fence_ops fence_array_ops; > > > > /** > > + * fence_is_array - check if a fence is from the array subsclass > > + * > > + * Return true if it is a fence_array and false otherwise. > > + */ > > +static inline bool fence_is_array(struct fence *fence) > > +{ > > + return (fence->ops == &fence_array_ops) ? true : false; > > Just return fence->ops == &fence_array_ops; It's a logical operation, it > is already a boolean. With that, > > Reviewed-by: Chris Wilson Oops, this needs an EXPORT_SYMBOL(fence_array_ops); -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] dma-buf/fence-array: add fence_is_array() Date: Thu, 30 Jun 2016 22:55:54 +0100 Message-ID: <20160630215554.GA28931@nuc-i3427.alporthouse.com> References: <1467295788-6422-1-git-send-email-gustavo@padovan.org> <1467295788-6422-2-git-send-email-gustavo@padovan.org> <20160630142359.GC28577@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 942A16E156 for ; Thu, 30 Jun 2016 21:55:59 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id r201so804118wme.0 for ; Thu, 30 Jun 2016 14:55:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160630142359.GC28577@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgMDM6MjM6NTlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgSnVuIDMwLCAyMDE2IGF0IDExOjA5OjQ3QU0gLTAzMDAsIEd1c3Rhdm8g UGFkb3ZhbiB3cm90ZToKPiA+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFu QGNvbGxhYm9yYS5jby51az4KPiA+IAo+ID4gQWRkIGhlbHBlciB0byBjaGVjayBpZiBmZW5jZSBp cyBhcnJheS4KPiA+IAo+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+ID4gQ2M6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4K PiA+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxh Ym9yYS5jby51az4KPiA+IC0tLQo+ID4gIGluY2x1ZGUvbGludXgvZmVuY2UtYXJyYXkuaCB8IDEw ICsrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9mZW5jZS1hcnJheS5oIGIvaW5jbHVkZS9saW51 eC9mZW5jZS1hcnJheS5oCj4gPiBpbmRleCA4NmJhYWE0Li5kMmU5ZjQwIDEwMDY0NAo+ID4gLS0t IGEvaW5jbHVkZS9saW51eC9mZW5jZS1hcnJheS5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2Zl bmNlLWFycmF5LmgKPiA+IEBAIC01Miw2ICs1MiwxNiBAQCBzdHJ1Y3QgZmVuY2VfYXJyYXkgewo+ ID4gIGV4dGVybiBjb25zdCBzdHJ1Y3QgZmVuY2Vfb3BzIGZlbmNlX2FycmF5X29wczsKPiA+ICAK PiA+ICAvKioKPiA+ICsgKiBmZW5jZV9pc19hcnJheSAtIGNoZWNrIGlmIGEgZmVuY2UgaXMgZnJv bSB0aGUgYXJyYXkgc3Vic2NsYXNzCj4gPiArICoKPiA+ICsgKiBSZXR1cm4gdHJ1ZSBpZiBpdCBp cyBhIGZlbmNlX2FycmF5IGFuZCBmYWxzZSBvdGhlcndpc2UuCj4gPiArICovCj4gPiArc3RhdGlj IGlubGluZSBib29sIGZlbmNlX2lzX2FycmF5KHN0cnVjdCBmZW5jZSAqZmVuY2UpCj4gPiArewo+ ID4gKwlyZXR1cm4gKGZlbmNlLT5vcHMgPT0gJmZlbmNlX2FycmF5X29wcykgPyB0cnVlIDogZmFs c2U7Cj4gCj4gSnVzdCByZXR1cm4gZmVuY2UtPm9wcyA9PSAmZmVuY2VfYXJyYXlfb3BzOyBJdCdz IGEgbG9naWNhbCBvcGVyYXRpb24sIGl0Cj4gaXMgYWxyZWFkeSBhIGJvb2xlYW4uIFdpdGggdGhh dCwKPiAKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+CgpPb3BzLCB0aGlzIG5lZWRzIGFuIEVYUE9SVF9TWU1CT0woZmVuY2VfYXJyYXlfb3BzKTsK LUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK