All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	haozhong.zhang@intel.com
Subject: Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch
Date: Thu, 30 Jun 2016 22:01:37 -0300	[thread overview]
Message-ID: <20160701010134.GA3372@amt.cnet> (raw)
In-Reply-To: <1467310337-3201-1-git-send-email-ehabkost@redhat.com>

On Thu, Jun 30, 2016 at 03:12:17PM -0300, Eduardo Habkost wrote:
> Improve the TSC frequency mismatch warning to show the host and
> VM TSC frequencies.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/kvm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index f3698f1..9679415 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
>                         -ENOTSUP;
>          if (cur_freq <= 0 || cur_freq != env->tsc_khz) {
>              error_report("warning: TSC frequency mismatch between "
> -                         "VM and host, and TSC scaling unavailable");
> +                         "VM (%" PRId64 " kHz) and host (%d kHz), "
> +                         "and TSC scaling unavailable",
> +                         env->tsc_khz, cur_freq);
>              return r;
>          }
>      }
> -- 
> 2.5.5

ACK 

      parent reply	other threads:[~2016-07-01  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 18:12 [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch Eduardo Habkost
2016-06-30 19:03 ` Dr. David Alan Gilbert
2016-07-01  1:01 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160701010134.GA3372@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=haozhong.zhang@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.