From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Fri, 01 Jul 2016 01:48:53 +0000 Subject: Re: [PATCH v4 19/22] sh: IO-DATA HDL-U (a,k.a landisk) IRQCHIP driver Message-Id: <20160701014853.GA29009@rob-hp-laptop> List-Id: References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-20-git-send-email-ysato@users.sourceforge.jp> In-Reply-To: <1467207667-15768-20-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoshinori Sato Cc: devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jun 29, 2016 at 10:41:04PM +0900, Yoshinori Sato wrote: > Changes v4 > - split patches > - remove unneeded line > - example update > > Signed-off-by: Yoshinori Sato > --- > .../interrupt-controller/iodata-landisk.txt | 31 ++++++++++ > drivers/irqchip/Makefile | 2 +- > drivers/irqchip/irq-io-landisk.c | 72 ++++++++++++++++++++++ > 3 files changed, 104 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > create mode 100644 drivers/irqchip/irq-io-landisk.c > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > new file mode 100644 > index 0000000..cf461dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > @@ -0,0 +1,31 @@ > +DT bindings for the I/O DATA HDL-U interrupt controller > + > +Required properties: > + > + - compatible: has to be "iodata,landisk-intc". > + > + - reg: Base address and length of interrupt controller register. > + > + - interrupt-controller: Identifies the node as an interrupt controller. > + > + - #interrupt-cells: has to be <1>: an interrupt index. > + > + - interrupt-map: Interrupt mapping on parent controller. interrupt-controller and interrupt-map are supposed to be mutually exclusive, so you should probably drop interrupt-controller. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752382AbcGACHJ (ORCPT ); Thu, 30 Jun 2016 22:07:09 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:33821 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbcGACHH (ORCPT ); Thu, 30 Jun 2016 22:07:07 -0400 Date: Thu, 30 Jun 2016 20:48:53 -0500 From: Rob Herring To: Yoshinori Sato Cc: devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 19/22] sh: IO-DATA HDL-U (a,k.a landisk) IRQCHIP driver Message-ID: <20160701014853.GA29009@rob-hp-laptop> References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-20-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467207667-15768-20-git-send-email-ysato@users.sourceforge.jp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2016 at 10:41:04PM +0900, Yoshinori Sato wrote: > Changes v4 > - split patches > - remove unneeded line > - example update > > Signed-off-by: Yoshinori Sato > --- > .../interrupt-controller/iodata-landisk.txt | 31 ++++++++++ > drivers/irqchip/Makefile | 2 +- > drivers/irqchip/irq-io-landisk.c | 72 ++++++++++++++++++++++ > 3 files changed, 104 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > create mode 100644 drivers/irqchip/irq-io-landisk.c > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > new file mode 100644 > index 0000000..cf461dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt > @@ -0,0 +1,31 @@ > +DT bindings for the I/O DATA HDL-U interrupt controller > + > +Required properties: > + > + - compatible: has to be "iodata,landisk-intc". > + > + - reg: Base address and length of interrupt controller register. > + > + - interrupt-controller: Identifies the node as an interrupt controller. > + > + - #interrupt-cells: has to be <1>: an interrupt index. > + > + - interrupt-map: Interrupt mapping on parent controller. interrupt-controller and interrupt-map are supposed to be mutually exclusive, so you should probably drop interrupt-controller. Rob