From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751938AbcGAMov (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jul 2016 08:44:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60585 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750702AbcGAMot (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jul 2016 08:44:49 -0400
Date: Fri, 1 Jul 2016 14:44:21 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrew Honig <ahonig@google.com>, linux-kernel@vger.kernel.org,
        kvm <kvm@vger.kernel.org>, "Lan, Tianyu" <tianyu.lan@intel.com>,
        Igor Mammedov <imammedo@redhat.com>, Jan Kiszka <jan.kiszka@web.de>,
        Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v1 03/11] KVM: x86: dynamic kvm_apic_map
Message-ID: <20160701124421.GA2301@potion>
References: <20160630205429.16480-1-rkrcmar@redhat.com>
 <20160630205429.16480-4-rkrcmar@redhat.com>
 <CAKB9nXt0N8-asM46ERcRr5Q53LJfqyGa8jBSXoFo1dru-kjwEw@mail.gmail.com>
 <f483a0a7-08c5-8329-1078-7b00fe7ef404@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f483a0a7-08c5-8329-1078-7b00fe7ef404@redhat.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 01 Jul 2016 12:44:25 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-07-01 10:42+0200, Paolo Bonzini:
> On 01/07/2016 00:15, Andrew Honig wrote:
>>> > +       /* kvm_apic_map_get_logical_dest() expects multiples of 16 */
>>> > +       size = round_up(max_id + 1, 16);
>> Now that you're using the full range of apic_id values, could this
>> calculation overflow?  Perhaps max_id could be u64?
> 
> Good point, but I wonder if it's a good idea to let userspace allocate
> 32 GB of memory. :)

Yes, both could happen.  I'll change it to u64 to make it future proof.

> Let's put a limit on the maximum supported APIC ID, and report it
> through KVM_CHECK_EXTENSION on the new KVM_CAP_X2APIC_API capability.
> If 767 is enough for Knights Landing, the allocation below fits in two
> pages.  If you need to make it higher, please change the allocation to
> use kvm_kvzalloc and kvfree.

We sort of have a capability for maximum APIC ID, KVM_MAX_VCPU_ID,
because VCPU ID is initial APIC ID and x2APIC ID should always be the
initial APIC ID.

Userspace is able to change x2APIC with LAPIC_GET/SET ioctl -- what
about forbidding that?

> Last but not least...
> 
> >> > +       new = kzalloc(sizeof(struct kvm_apic_map) +
> >> > +                     sizeof(struct kvm_lapic) * size, GFP_KERNEL);
>                            ^^^^^^^^^^^^^^^^^^^^^^^^
> ... the sizeof here must be sizeof(struct kvm_lapic *).

Oops, thanks.