All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Omar Sandoval <osandov@osandov.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	kernel-team@fb.com
Subject: Re: [RFC PATCH] coredump: avoid ext4 auto_da_alloc for core file
Date: Mon, 4 Jul 2016 11:11:37 -0400	[thread overview]
Message-ID: <20160704151137.GE29557@thunk.org> (raw)
In-Reply-To: <20160704022455.GA28883@thunk.org>

On Sun, Jul 03, 2016 at 10:24:55PM -0400, Theodore Ts'o wrote:
> From bf21c027d84ded545d2c08fa01fd184d29641458 Mon Sep 17 00:00:00 2001
> From: Theodore Ts'o <tytso@mit.edu>
> Date: Sun, 3 Jul 2016 22:20:49 -0400
> Subject: [PATCH] ext4: in ext4_setattr(), only call ext4_truncate() if there is no data to drop
> 
> If there are no blocks associated with the inode (and no inline data),
> there's no point calling ext4_truncate().  This avoids setting the
> replace-via-truncate hueristic if there is an attempt to truncate a
> file which is already zero-length --- which is something that happens
> in the core dumping code, in case there is an already existing core
> file.  In the comon case, there is not a previous core file, so by not
> enabling the replace-via-truncate hueristic, we can speed up core
> dumps.
> 
> Reported-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

This patch is buggy; when I tried running regression tests, it failed
early.  So you probably want to skip this.

					- Ted
					

  reply	other threads:[~2016-07-04 15:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 17:42 [RFC PATCH] coredump: avoid ext4 auto_da_alloc for core file Omar Sandoval
2016-06-29 18:34 ` Omar Sandoval
2016-07-04  2:24   ` Theodore Ts'o
2016-07-04 15:11     ` Theodore Ts'o [this message]
2016-07-05 13:42 ` Josef Bacik
2016-07-05 14:37   ` Theodore Ts'o
2016-07-05 15:01     ` Josef Bacik
2016-07-05 16:57       ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704151137.GE29557@thunk.org \
    --to=tytso@mit.edu \
    --cc=kernel-team@fb.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=osandov@osandov.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.