From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933192AbcGERRt (ORCPT ); Tue, 5 Jul 2016 13:17:49 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38754 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932971AbcGERRq (ORCPT ); Tue, 5 Jul 2016 13:17:46 -0400 Date: Tue, 05 Jul 2016 10:17:45 -0700 (PDT) Message-Id: <20160705.101745.2191999709401594106.davem@davemloft.net> To: dhowells@redhat.com Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 06/24] rxrpc: Dup the main conn list for the proc interface From: David Miller In-Reply-To: <146772437424.21657.5653571141789810019.stgit@warthog.procyon.org.uk> References: <146772433082.21657.14046392058484946464.stgit@warthog.procyon.org.uk> <146772437424.21657.5653571141789810019.stgit@warthog.procyon.org.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Jul 2016 10:17:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells Date: Tue, 05 Jul 2016 14:12:54 +0100 > The main connection list is used for two independent purposes: primarily it > is used to find connections to reap and secondarily it is used to list > connections in procfs. > > Split the procfs list out from the reap list. This allows the reap list to > be phased out in stages as the client conns and service conns acquire their > own separate connection management strategies. > > Whilst we're at it, use the address information stored in conn->proto when > displaying through procfs rather than accessing the peer record. > > Signed-off-by: David Howells Wouldn't it be better to just code the proc stuff to walk whatever table the rest of the stack uses to hold all of the connections as TCP et al. do?