All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH for-next 1/3] IB/core: Add optional AV attribute for Raw Packet QP in INIT to RTR
Date: Tue, 5 Jul 2016 09:17:02 +0300	[thread overview]
Message-ID: <20160705061702.GA15009@leon.nu> (raw)
In-Reply-To: <20160704153337.GB23122-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Mon, Jul 04, 2016 at 09:33:37AM -0600, Jason Gunthorpe wrote:
> On Mon, Jul 04, 2016 at 12:51:00AM +0300, Or Gerlitz wrote:
> > On Sun, Jul 3, 2016 at 3:42 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > > From: Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >
> > > In order to configure QoS for Raw Packet QP, the user passes the SL
> > > in the AV attribute when modifying the QP from INIT to RTR state.
> > >
> > > This SL is used later on to set the Ethernet Priority of the QP.
> > >
> > > Until today, we couldn't pass the AV attribute for Raw Packet QP
> > > because it was blocked in the QP state transition matrix. This
> > > patch adds the AV as optional in INIT to RTR.
> > >
> > > Fixes: 8a51866f0810 ('IB: Add ib_modify_qp_is_ok() library function')
> > 
> > This commit is 10y old and was done way before RAW Packet QP was added
> > to the kernel, please fix your Fixes: line...
> 
> It isn't a fixes if you are adding a new feature.

You are right, I'll resubmit.

> 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-07-05  6:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 12:42 [PATCH for-next 0/3] Raw Packet QP Fixes for 4.8 Leon Romanovsky
     [not found] ` <1467549727-23479-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-03 12:42   ` [PATCH for-next 1/3] IB/core: Add optional AV attribute for Raw Packet QP in INIT to RTR Leon Romanovsky
     [not found]     ` <1467549727-23479-2-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-03 21:51       ` Or Gerlitz
     [not found]         ` <CAJ3xEMiaD99d96RKGwD3OpgEOn0RXjXoaRuFWT6PJdXQSOo5rQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-04 15:33           ` Jason Gunthorpe
     [not found]             ` <20160704153337.GB23122-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-05  6:17               ` Leon Romanovsky [this message]
2016-07-03 12:42   ` [PATCH for-next 2/3] IB/core: Fix ib_resolve_eth_dmac for Raw Packet QP Leon Romanovsky
     [not found]     ` <1467549727-23479-3-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-03 13:52       ` Or Gerlitz
     [not found]         ` <CAJ3xEMg+kqmEQ7B_JAKGnu3ubwu5f-40jbeL4Wg9udUeoxEZJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-04  6:10           ` Talat Batheesh
     [not found]             ` <C8D4A0D8-4D97-4BAB-8FE4-DDEDDDAF9775-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-07-04 12:30               ` Or Gerlitz
2016-07-03 12:42   ` [PATCH for-next 3/3] IB/mlx5: Fix mlx5_set_path " Leon Romanovsky
     [not found]     ` <1467549727-23479-4-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-03 21:55       ` Or Gerlitz
     [not found]         ` <CAJ3xEMhZiBjQwjgXj8peLYW4wETEE96UJ8BC7TLyO0G_jn-iBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-04  5:14           ` Leon Romanovsky
     [not found]             ` <20160704051403.GB5289-2ukJVAZIZ/Y@public.gmane.org>
2016-07-04 12:29               ` Or Gerlitz
2016-07-05  6:20   ` [PATCH for-next 0/3] Raw Packet QP Fixes for 4.8 Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705061702.GA15009@leon.nu \
    --to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.