From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Gregory Subject: Re: [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. Date: Tue, 5 Jul 2016 10:07:47 +0100 Message-ID: <20160705090747.GC18338@xora-haswell.xora.org.uk> References: <1466034240-22694-1-git-send-email-stripathi@apm.com> <6691907.FIx2xYmxSs@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44052 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbcGEJHv (ORCPT ); Tue, 5 Jul 2016 05:07:51 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Suman Tripathi Cc: Arnd Bergmann , "devicetree@vger.kernel.org" , Mark Langsdorf , "linux-ide@vger.kernel.org" , Jon Masters , patches , Tejun Heo , Olof Johansson , linux-arm-kernel On Tue, Jun 21, 2016 at 04:31:38PM -0700, Suman Tripathi wrote: > Hi Arnd, > > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was discussed when AMD Seattle SoC had the same issue and it was decided in standards body and on LKML that using PCI device classes for non PCI devices was fine. Example from Overdrive DSDT Device (AHC0) { Name (_HID, "AMDI0600") // _HID: Hardware ID Name (_UID, 0x00) // _UID: Unique ID Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute Name (_CLS, Package (0x03) // _CLS: Class Code { 0x01, 0x06, 0x01 }) ... Graeme From mboxrd@z Thu Jan 1 00:00:00 1970 From: gg@slimlogic.co.uk (Graeme Gregory) Date: Tue, 5 Jul 2016 10:07:47 +0100 Subject: [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware. In-Reply-To: References: <1466034240-22694-1-git-send-email-stripathi@apm.com> <6691907.FIx2xYmxSs@wuerfel> Message-ID: <20160705090747.GC18338@xora-haswell.xora.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 21, 2016 at 04:31:38PM -0700, Suman Tripathi wrote: > Hi Arnd, > > On Tue, Jun 21, 2016 at 11:08 AM, Suman Tripathi wrote: > > On Wed, Jun 15, 2016 at 11:54 PM, Arnd Bergmann wrote: > >> > >> On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote: > >> > This patch adds ACPI support for APM X-Gene AHCI controller in > >> > ahci_platform driver for v3 hardware. APM X-Gene AHCI controller > >> > v3 hardware is fully compliant with ahci_platform driver and requires > >> > no workaround quirk. > >> > > >> > Signed-off-by: Suman Tripathi > >> > --- > >> > drivers/ata/ahci_platform.c | 1 + > >> > 1 files changed, 1 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > >> > index 62a04c8..3395baf 100644 > >> > --- a/drivers/ata/ahci_platform.c > >> > +++ b/drivers/ata/ahci_platform.c > >> > @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match); > >> > > >> > static const struct acpi_device_id ahci_acpi_match[] = { > >> > { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) }, > >> > + { "APMC0D33", 0}, > >> > {}, > >> > }; > >> > MODULE_DEVICE_TABLE(acpi, ahci_acpi_match); > >> > > >> > >> Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been > > > > > > yeah it also works. Just thought that we need something different as > > our's is a non-PCI SATA. > > Are you suggesting to introduce a new class ACPI_DEVICE_CLASS for > non-pci ahci ? or to reuse the existing PCI_CLASS_STORAGE_SATA_AHCI ? This was discussed when AMD Seattle SoC had the same issue and it was decided in standards body and on LKML that using PCI device classes for non PCI devices was fine. Example from Overdrive DSDT Device (AHC0) { Name (_HID, "AMDI0600") // _HID: Hardware ID Name (_UID, 0x00) // _UID: Unique ID Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute Name (_CLS, Package (0x03) // _CLS: Class Code { 0x01, 0x06, 0x01 }) ... Graeme