From mboxrd@z Thu Jan  1 00:00:00 1970
From: Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT
 support in arm_arch_timer
Date: Tue, 5 Jul 2016 15:18:58 +0100
Message-ID: <20160705141858.GD18338@xora-haswell.xora.org.uk>
References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org>
 <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org>
 <20160701152340.GO12735@arm.com>
 <2183745.J7YpvxXQ47@vostro.rjw.lan>
 <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50794 "EHLO
	out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752088AbcGEOTD (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Tue, 5 Jul 2016 10:19:03 -0400
Content-Disposition: inline
In-Reply-To: <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>, Hanjun Guo <hanjun.guo@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Fu Wei <fu.wei@linaro.org>, Len Brown <lenb@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <marc.zyngier@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington <cov@codeaurora.org>, Timur Tabi <timur@codeaurora.org>, G Gregory <graeme.gregory@linaro.org>, Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>, wei@redhat.com, Arnd Bergmann <arnd@arndb.de>, Wim Van Sebroeck <wim@iguana.be>, Suravee Suthikulanit <Sur>

On Mon, Jul 04, 2016 at 02:53:20PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 1, 2016 at 11:04 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, July 01, 2016 04:23:40 PM Will Deacon wrote:
> >> On Thu, Jun 30, 2016 at 09:48:02PM +0800, Hanjun Guo wrote:
> >> > On 2016/6/30 21:27, Rafael J. Wysocki wrote:
> >> > >On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote:
> >> > >>GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
> >> > >>ACPI spec, I think it can stay in drivers/acpi/ from this point
> >> > >>of view, am I right?
> >> > >
> >> > >The question is not "Can it?", but "Does it need to?".
> >> > >
> >> > >It is in the spec, but still there's only one architecture needing it.
> >> > >
> >> > >There is no way to test it on any other architecture and no reason to build it
> >> > >for any other architecture, so why does it need to be located in drivers/acpi/ ?
> >> >
> >> > I'm fine to move it to other places such as arch/arm64/kernel/, but I
> >> > would like to ask ARM64 maintainer's suggestion for this.
> >> >
> >> > Will, Catalin, what's your opinion on this?
> >>
> >> We don't have any device-tree code for the architected timer under
> >> arch/arm64, so I don't see why we should need anything for ACPI either.
> >
> > And I don't see a reason for the GTDT code to be there in drivers/acpi/.
> >
> > What gives?
> 
> Well, since there are things like acpi_lpss in there, my position here
> is kind of weak. :-)
> 
> That said I'm not particularly happy with having them in
> drivers/acpi/, so I definitely won't object against attempts to moving
> them somewhere else.
> 
> > Maybe it should go to the same place as the analogus DT code, then?
> 
> I'm mostly concerned about how (and by whom) that code is going to be
> maintained going forward, though.  I also think it should be made
> clear that it is ARM64-only.
> 

So is this a documentation issue in which case Fu Wei can add that to
the file to explain its limited to ARM64. Or we could even rename the
file acpi_arm64_gtdt.c

It seems a pity as the comment on this series were minors to block
things on a filename/location.

Graeme


From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754903AbcGEOTG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 10:19:06 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50794 "EHLO
	out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752088AbcGEOTD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 10:19:03 -0400
X-Sasl-enc: 92wUR5g1UwZsR4VXWjCXgQlIy09Fn8OaldLRcYato1HG 1467728341
Date: Tue, 5 Jul 2016 15:18:58 +0100
From: Graeme Gregory <gg@slimlogic.co.uk>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>, Hanjun Guo <hanjun.guo@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>, Fu Wei <fu.wei@linaro.org>,
        Len Brown <lenb@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <marc.zyngier@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        rruigrok@codeaurora.org, harba@codeaurora.org,
        Christopher Covington <cov@codeaurora.org>,
        Timur Tabi <timur@codeaurora.org>,
        G Gregory <graeme.gregory@linaro.org>, Al Stone <al.stone@linaro.org>,
        Jon Masters <jcm@redhat.com>, wei@redhat.com,
        Arnd Bergmann <arnd@arndb.de>, Wim Van Sebroeck <wim@iguana.be>,
        Suravee Suthikulanit <Suravee.Suthikulpanit@amd.com>,
        Leo Duran <leo.duran@amd.com>, steve.capper@linaro.org,
        leif.lindholm@linaro.org
Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT
 support in arm_arch_timer
Message-ID: <20160705141858.GD18338@xora-haswell.xora.org.uk>
References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org>
 <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org>
 <20160701152340.GO12735@arm.com>
 <2183745.J7YpvxXQ47@vostro.rjw.lan>
 <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 04, 2016 at 02:53:20PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 1, 2016 at 11:04 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, July 01, 2016 04:23:40 PM Will Deacon wrote:
> >> On Thu, Jun 30, 2016 at 09:48:02PM +0800, Hanjun Guo wrote:
> >> > On 2016/6/30 21:27, Rafael J. Wysocki wrote:
> >> > >On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote:
> >> > >>GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
> >> > >>ACPI spec, I think it can stay in drivers/acpi/ from this point
> >> > >>of view, am I right?
> >> > >
> >> > >The question is not "Can it?", but "Does it need to?".
> >> > >
> >> > >It is in the spec, but still there's only one architecture needing it.
> >> > >
> >> > >There is no way to test it on any other architecture and no reason to build it
> >> > >for any other architecture, so why does it need to be located in drivers/acpi/ ?
> >> >
> >> > I'm fine to move it to other places such as arch/arm64/kernel/, but I
> >> > would like to ask ARM64 maintainer's suggestion for this.
> >> >
> >> > Will, Catalin, what's your opinion on this?
> >>
> >> We don't have any device-tree code for the architected timer under
> >> arch/arm64, so I don't see why we should need anything for ACPI either.
> >
> > And I don't see a reason for the GTDT code to be there in drivers/acpi/.
> >
> > What gives?
> 
> Well, since there are things like acpi_lpss in there, my position here
> is kind of weak. :-)
> 
> That said I'm not particularly happy with having them in
> drivers/acpi/, so I definitely won't object against attempts to moving
> them somewhere else.
> 
> > Maybe it should go to the same place as the analogus DT code, then?
> 
> I'm mostly concerned about how (and by whom) that code is going to be
> maintained going forward, though.  I also think it should be made
> clear that it is ARM64-only.
> 

So is this a documentation issue in which case Fu Wei can add that to
the file to explain its limited to ARM64. Or we could even rename the
file acpi_arm64_gtdt.c

It seems a pity as the comment on this series were minors to block
things on a filename/location.

Graeme

From mboxrd@z Thu Jan  1 00:00:00 1970
From: gg@slimlogic.co.uk (Graeme Gregory)
Date: Tue, 5 Jul 2016 15:18:58 +0100
Subject: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT
 support in arm_arch_timer
In-Reply-To: <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org>
 <57714bed-3f9c-90c2-ac30-2d462d8a06d4@linaro.org>
 <20160701152340.GO12735@arm.com>
 <2183745.J7YpvxXQ47@vostro.rjw.lan>
 <CAJZ5v0iFcjxQV9YV2KaXGAPRBM8M2xxPm5e2b4uhwYAZZtndPg@mail.gmail.com>
Message-ID: <20160705141858.GD18338@xora-haswell.xora.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Mon, Jul 04, 2016 at 02:53:20PM +0200, Rafael J. Wysocki wrote:
> On Fri, Jul 1, 2016 at 11:04 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, July 01, 2016 04:23:40 PM Will Deacon wrote:
> >> On Thu, Jun 30, 2016 at 09:48:02PM +0800, Hanjun Guo wrote:
> >> > On 2016/6/30 21:27, Rafael J. Wysocki wrote:
> >> > >On Thursday, June 30, 2016 10:10:02 AM Hanjun Guo wrote:
> >> > >>GTDT is part of ACPI spec, drivers/acpi/ is for driver code of
> >> > >>ACPI spec, I think it can stay in drivers/acpi/ from this point
> >> > >>of view, am I right?
> >> > >
> >> > >The question is not "Can it?", but "Does it need to?".
> >> > >
> >> > >It is in the spec, but still there's only one architecture needing it.
> >> > >
> >> > >There is no way to test it on any other architecture and no reason to build it
> >> > >for any other architecture, so why does it need to be located in drivers/acpi/ ?
> >> >
> >> > I'm fine to move it to other places such as arch/arm64/kernel/, but I
> >> > would like to ask ARM64 maintainer's suggestion for this.
> >> >
> >> > Will, Catalin, what's your opinion on this?
> >>
> >> We don't have any device-tree code for the architected timer under
> >> arch/arm64, so I don't see why we should need anything for ACPI either.
> >
> > And I don't see a reason for the GTDT code to be there in drivers/acpi/.
> >
> > What gives?
> 
> Well, since there are things like acpi_lpss in there, my position here
> is kind of weak. :-)
> 
> That said I'm not particularly happy with having them in
> drivers/acpi/, so I definitely won't object against attempts to moving
> them somewhere else.
> 
> > Maybe it should go to the same place as the analogus DT code, then?
> 
> I'm mostly concerned about how (and by whom) that code is going to be
> maintained going forward, though.  I also think it should be made
> clear that it is ARM64-only.
> 

So is this a documentation issue in which case Fu Wei can add that to
the file to explain its limited to ARM64. Or we could even rename the
file acpi_arm64_gtdt.c

It seems a pity as the comment on this series were minors to block
things on a filename/location.

Graeme