From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231AbcGEOcU (ORCPT ); Tue, 5 Jul 2016 10:32:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45058 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754606AbcGEOcR (ORCPT ); Tue, 5 Jul 2016 10:32:17 -0400 Date: Tue, 5 Jul 2016 16:31:35 +0200 From: Mark Brown To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, Liam Girdwood , Heiko Stuebner , linux-rockchip@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Milo Kim , Doug Anderson , Caesar Wang , Stephen Barber , Brian Norris , Ajit Pal Singh , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , kernel@stlinux.com, Laxman Dewangan Message-ID: <20160705143135.GY6247@sirena.org.uk> References: <1465895602-31008-1-git-send-email-boris.brezillon@free-electrons.com> <1465895602-31008-12-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2uZVBGM+62ujkrHk" Content-Disposition: inline In-Reply-To: <1465895602-31008-12-git-send-email-boris.brezillon@free-electrons.com> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.22.87 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 11/14] regulator: pwm: Properly initialize the ->state field X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2uZVBGM+62ujkrHk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 14, 2016 at 11:13:19AM +0200, Boris Brezillon wrote: > The ->state field is currently initialized to 0, thus referencing the > voltage selector at index 0, which might not reflect the current > voltage value. > If possible, retrieve the current voltage selector from the PWM state, > else return -EINVAL. Acked-by: Mark Brown --2uZVBGM+62ujkrHk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXe8TBAAoJECTWi3JdVIfQ0KEH/js7vQtbg9Yd+SBsg8YV0Gjg SDyw2+AoUsUcrWroPFZTvSYTfRJ9vgKjw8A0ayJcriAM1kHVgk1L8uI39LUMU7rJ pZmuEVTbTgFFkSwqWvcrKl2WqVJYFtKjX5hg71AnOVhVaszHzNZBw5JDy8mx/suz L+EZXQkPKLCPpTLiCyroiN7gZm0i4qfyfsCIl+Qdz7gFklCaLTPlFIa90yyJ46ak TcJkmlv0+JN9UQRSH1vcbCoX5YigPxRzPXxbX3N0X7BcDOwd4q+hHkg7l28GlLZC ZkjnKvyewy6MtN8b0A5HfrikmCJW4ioqcmAJVHpQGZblVpT+BH1PG6oApjA20f8= =BUTQ -----END PGP SIGNATURE----- --2uZVBGM+62ujkrHk-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v3 11/14] regulator: pwm: Properly initialize the ->state field Date: Tue, 5 Jul 2016 16:31:35 +0200 Message-ID: <20160705143135.GY6247@sirena.org.uk> References: <1465895602-31008-1-git-send-email-boris.brezillon@free-electrons.com> <1465895602-31008-12-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8417070831152451929==" Return-path: In-Reply-To: <1465895602-31008-12-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Boris Brezillon Cc: Mark Rutland , Milo Kim , Heiko Stuebner , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , Thierry Reding , kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, Brian Norris , Stephen Barber , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , Doug Anderson , Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maxime Coquelin , Srinivas Kandagatla , Patrice Chotard , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Laxman Dewangan , Kumar Gala , Ajit Pal Singh List-Id: devicetree@vger.kernel.org --===============8417070831152451929== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2uZVBGM+62ujkrHk" Content-Disposition: inline --2uZVBGM+62ujkrHk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 14, 2016 at 11:13:19AM +0200, Boris Brezillon wrote: > The ->state field is currently initialized to 0, thus referencing the > voltage selector at index 0, which might not reflect the current > voltage value. > If possible, retrieve the current voltage selector from the PWM state, > else return -EINVAL. Acked-by: Mark Brown --2uZVBGM+62ujkrHk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXe8TBAAoJECTWi3JdVIfQ0KEH/js7vQtbg9Yd+SBsg8YV0Gjg SDyw2+AoUsUcrWroPFZTvSYTfRJ9vgKjw8A0ayJcriAM1kHVgk1L8uI39LUMU7rJ pZmuEVTbTgFFkSwqWvcrKl2WqVJYFtKjX5hg71AnOVhVaszHzNZBw5JDy8mx/suz L+EZXQkPKLCPpTLiCyroiN7gZm0i4qfyfsCIl+Qdz7gFklCaLTPlFIa90yyJ46ak TcJkmlv0+JN9UQRSH1vcbCoX5YigPxRzPXxbX3N0X7BcDOwd4q+hHkg7l28GlLZC ZkjnKvyewy6MtN8b0A5HfrikmCJW4ioqcmAJVHpQGZblVpT+BH1PG6oApjA20f8= =BUTQ -----END PGP SIGNATURE----- --2uZVBGM+62ujkrHk-- --===============8417070831152451929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============8417070831152451929==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Tue, 5 Jul 2016 16:31:35 +0200 Subject: [PATCH v3 11/14] regulator: pwm: Properly initialize the ->state field In-Reply-To: <1465895602-31008-12-git-send-email-boris.brezillon@free-electrons.com> References: <1465895602-31008-1-git-send-email-boris.brezillon@free-electrons.com> <1465895602-31008-12-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <20160705143135.GY6247@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 14, 2016 at 11:13:19AM +0200, Boris Brezillon wrote: > The ->state field is currently initialized to 0, thus referencing the > voltage selector at index 0, which might not reflect the current > voltage value. > If possible, retrieve the current voltage selector from the PWM state, > else return -EINVAL. Acked-by: Mark Brown -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: