From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbcGES5o (ORCPT ); Tue, 5 Jul 2016 14:57:44 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:60382 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752541AbcGES5n (ORCPT ); Tue, 5 Jul 2016 14:57:43 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3167:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:4605:5007:6117:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14181:14659:14721:21080:21212:21220:30029:30054:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: skirt21_7dc71cdf2f05 X-Filterd-Recvd-Size: 2178 Date: Tue, 5 Jul 2016 14:57:32 -0400 From: Steven Rostedt To: Borislav Petkov Cc: LKML , Andrew Morton , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Message-ID: <20160705145732.4b6dbd55@gandalf.local.home> In-Reply-To: <20160705184517.GF12027@pd.tnic> References: <1467642292-15671-1-git-send-email-bp@alien8.de> <1467642292-15671-2-git-send-email-bp@alien8.de> <20160705142648.57456ef8@gandalf.local.home> <20160705184517.GF12027@pd.tnic> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jul 2016 20:45:17 +0200 Borislav Petkov wrote: > On Tue, Jul 05, 2016 at 02:26:48PM -0400, Steven Rostedt wrote: > > > + if (rs->missed) > > > + printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n", > > > + current->comm, rs->missed); > > > > Is the comm important? > > Yes, we wanna dump the task name which called devkmsg_release(). > > > Maybe add the function that called it? > > > > "%pS", _THIS_IP_ > > > > Perhaps add __always_inline, as _THIS_IP_ will point into the function > > that calls this? > > That would inadvertently be devkmsg_release() in this use case. But > we want to dump the task name which opened and spat so much crap into > /dev/kmsg so as to cause the ratelimiting to hit. > Perhaps we should show both, unless you don't think this will ever be used by anything other than devkmsg? -- Steve