From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbcGEQRE (ORCPT ); Tue, 5 Jul 2016 12:17:04 -0400 Received: from outbound1.eu.mailhop.org ([52.28.251.132]:63437 "EHLO outbound1.eu.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbcGEQRB (ORCPT ); Tue, 5 Jul 2016 12:17:01 -0400 X-MHO-User: eaa5085b-42cb-11e6-ac92-3142cfe117f2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.78.160 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io 69C588005C Date: Tue, 5 Jul 2016 16:16:54 +0000 From: Jason Cooper To: Mason Cc: Sebastian Frias , LKML , Thomas Gleixner , Marc Zyngier Subject: Re: [RFC PATCH v1] irqchip: add support for SMP irq router Message-ID: <20160705161654.GH3348@io.lakedaemon.net> References: <577542D1.4070307@laposte.net> <577A5260.3070001@free.fr> <577BA854.6090503@laposte.net> <20160705144151.GE3348@io.lakedaemon.net> <577BCD1D.6060301@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577BCD1D.6060301@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mason, On Tue, Jul 05, 2016 at 05:07:09PM +0200, Mason wrote: > Jason Cooper wrote: > > Sebastian Frias wrote: > >> Mason wrote: > >>> Sebastian Frias wrote: > >>> > >>>> .../sigma,smp87xx-irqrouter.txt | 69 +++ > >>> > >>> In the *actual* submission, we can't use a wildcard like smp87xx > >>> we'll have to use an actual part number. > >> > >> Are you sure? > >> That would hinder genericity. > >> Actually I wanted to call it "sigma,smp-irqrouter.txt" (or "sigma,smp,irqrouter.txt"). > > > > sigma,smp-irqrouter.txt should be fine. The devicetree maintainers > > should yelp if they want something different. > > Personally, I don't like "smp" because it's too easy to confuse that > for "symmetric multi-processor". Respectfully, it's not about what any of us 'likes'. If Sigma's marketing people inadvertently chose a bad acronym, then it is what it is. Trying to paper over it just adds unnecessary layers of complexity and confusion. A simple expansion of the acronym in a comment block or in the commit message is all that's needed to remove the ambiguity. > Come to think of it, I'm not sure the *name* of the file documenting > a binding is as important to DT maintainers as the compatible string. Correct. devicetee compatible strings need to be as specific as possible. In a series of compatible IP blocks, the string should refer to the first version in the series, e.g. sigma,smp8710 for a series of compatible IP blocks like 8710, 8712, 8715, 8724. If an 8751 came along with a different register layout or some other incompatibility, then a new string would be sigma,smp8751. So, 8710 uses "sigma,smp8710" 8712 uses "sigma,smp8710" 8715 uses "sigma,smp8710" 8724 uses "sigma,smp8710" 8751 uses "sigma,smp8751" 8754 uses "sigma,smp8751" thx, Jason.