From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbcGFCke (ORCPT ); Tue, 5 Jul 2016 22:40:34 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:54576 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbcGFCkb (ORCPT ); Tue, 5 Jul 2016 22:40:31 -0400 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 6 Jul 2016 11:41:19 +0900 From: Minchan Kim To: Ganesh Mahendran CC: , , , , , , Subject: Re: [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Message-ID: <20160706024119.GE13566@bbox> References: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com> <1467614999-4326-5-git-send-email-opensource.ganesh@gmail.com> MIME-Version: 1.0 In-Reply-To: <1467614999-4326-5-git-send-email-opensource.ganesh@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/07/06 11:40:27, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/07/06 11:40:27, Serialize complete at 2016/07/06 11:40:27 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2016 at 02:49:56PM +0800, Ganesh Mahendran wrote: > Currently, if a class can not be merged, the max objects of zspage > in that class may be calculated twice. > > This patch calculate max objects of zspage at the begin, and pass > the value to can_merge() to decide whether the class can be merged. > > Also this patch remove function get_maxobj_per_zspage(), as there > is no other place to call this funtion. > > Signed-off-by: Ganesh Mahendran Acked-by: Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f198.google.com (mail-io0-f198.google.com [209.85.223.198]) by kanga.kvack.org (Postfix) with ESMTP id E3731828E1 for ; Tue, 5 Jul 2016 22:40:30 -0400 (EDT) Received: by mail-io0-f198.google.com with SMTP id x68so448073493ioi.0 for ; Tue, 05 Jul 2016 19:40:30 -0700 (PDT) Received: from lgeamrelo12.lge.com (LGEAMRELO12.lge.com. [156.147.23.52]) by mx.google.com with ESMTP id 65si1226891iow.43.2016.07.05.19.40.29 for ; Tue, 05 Jul 2016 19:40:30 -0700 (PDT) Date: Wed, 6 Jul 2016 11:41:19 +0900 From: Minchan Kim Subject: Re: [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Message-ID: <20160706024119.GE13566@bbox> References: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com> <1467614999-4326-5-git-send-email-opensource.ganesh@gmail.com> MIME-Version: 1.0 In-Reply-To: <1467614999-4326-5-git-send-email-opensource.ganesh@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Ganesh Mahendran Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org, mingo@redhat.com On Mon, Jul 04, 2016 at 02:49:56PM +0800, Ganesh Mahendran wrote: > Currently, if a class can not be merged, the max objects of zspage > in that class may be calculated twice. > > This patch calculate max objects of zspage at the begin, and pass > the value to can_merge() to decide whether the class can be merged. > > Also this patch remove function get_maxobj_per_zspage(), as there > is no other place to call this funtion. > > Signed-off-by: Ganesh Mahendran Acked-by: Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org