From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512AbcGFQiH (ORCPT ); Wed, 6 Jul 2016 12:38:07 -0400 Received: from mail.windriver.com ([147.11.1.11]:63656 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbcGFQiF (ORCPT ); Wed, 6 Jul 2016 12:38:05 -0400 Date: Wed, 6 Jul 2016 12:38:00 -0400 From: Paul Gortmaker To: Mika Westerberg CC: , Lee Jones Subject: Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular Message-ID: <20160706163800.GH26134@windriver.com> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-4-paul.gortmaker@windriver.com> <20160705100821.GK23527@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160705100821.GK23527@lahna.fi.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular] On 05/07/2016 (Tue 13:08) Mika Westerberg wrote: > On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > drivers/mfd/Kconfig:config MFD_INTEL_MSIC > > drivers/mfd/Kconfig: bool "Intel MSIC" > > I would prefer if it could be turned to tristate instead. I don't see > any reasons why it should only be builtin. If I change it to tristate, it is still impossible to choose =m for it unless I revert your earlier commit forcing it to be built in. commit 15a713df4145ad2540f8d84c3f4de930806f6151 Author: Mika Westerberg Date: Thu Jan 26 17:35:05 2012 +0000 x86/config: Select MSIC MFD driver on Intel Medfield platform On Intel Medfield platform we use MSIC MFD driver to create necessary platform devices so it is essential to have the driver compiled into the kernel. If I revert that, then it is possible to choose =m and it compiles. (haven't completed modpost yet.. so may be missing symbols...) Paul. --