All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aar@pengutronix.de>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, Alexander Aring <aar@pengutronix.de>
Subject: [PATCHv4 bluetooth-next 5/8] 6lowpan: ndisc: set invalid unicast short addr to unspec
Date: Wed,  6 Jul 2016 23:32:28 +0200	[thread overview]
Message-ID: <20160706213231.23058-6-aar@pengutronix.de> (raw)
In-Reply-To: <20160706213231.23058-1-aar@pengutronix.de>

When receiving neighbour information with short address option field we
should check the complete range of invalid short addresses and set it to
one invalid address setting which is the unspecified address. This
address is also used when by creating at first a new neighbour entry to
indicate no short address is set.

Signed-off-by: Alexander Aring <aar@pengutronix.de>
---
 net/6lowpan/ndisc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/net/6lowpan/ndisc.c b/net/6lowpan/ndisc.c
index 79c5fa9..86450b7 100644
--- a/net/6lowpan/ndisc.c
+++ b/net/6lowpan/ndisc.c
@@ -97,10 +97,13 @@ static void lowpan_ndisc_802154_update(struct neighbour *n, u32 flags,
 	}
 
 	write_lock_bh(&n->lock);
-	if (lladdr_short)
+	if (lladdr_short) {
 		ieee802154_be16_to_le16(&neigh->short_addr, lladdr_short);
-	else
+		if (!lowpan_802154_is_valid_src_short_addr(neigh->short_addr))
+			neigh->short_addr = cpu_to_le16(IEEE802154_ADDR_SHORT_UNSPEC);
+	} else {
 		neigh->short_addr = cpu_to_le16(IEEE802154_ADDR_SHORT_UNSPEC);
+	}
 	write_unlock_bh(&n->lock);
 }
 
-- 
2.9.0


  parent reply	other threads:[~2016-07-06 21:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 21:32 [PATCHv4 bluetooth-next 0/8] ieee802154: pending/new fixes and cleanup/features Alexander Aring
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 1/8] ieee802154: add ieee802154_skb_dst_pan helper Alexander Aring
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 2/8] ieee802154: add ieee802154_skb_src_pan helper Alexander Aring
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 3/8] ieee802154: 6lowpan: fix intra pan id check Alexander Aring
2016-07-23 11:03   ` Alexander Aring
2016-07-25  6:31     ` Alexander Aring
2016-07-26 11:24       ` Michael Richardson
2016-07-26 11:24     ` Michael Richardson
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 4/8] ieee802154: fix skb get fc on big endian Alexander Aring
2016-07-06 21:32 ` Alexander Aring [this message]
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 6/8] atusb: don't change csma settings while set channel Alexander Aring
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 7/8] ieee802154: cleanup WARN_ON for fc fetch Alexander Aring
2016-07-08 11:23   ` Stefan Schmidt
2016-07-06 21:32 ` [PATCHv4 bluetooth-next 8/8] fakelb: allow to run as monitor Alexander Aring
2016-07-08 11:25   ` Stefan Schmidt
2016-07-08 11:24 ` [PATCHv4 bluetooth-next 0/8] ieee802154: pending/new fixes and cleanup/features Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160706213231.23058-6-aar@pengutronix.de \
    --to=aar@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.