From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756742AbcGGILr (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 04:11:47 -0400
Received: from mga03.intel.com ([134.134.136.65]:32457 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756277AbcGGILl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2016 04:11:41 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,324,1464678000"; 
   d="scan'208";a="990587261"
Date: Thu, 7 Jul 2016 11:11:30 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular
Message-ID: <20160707081130.GI23527@lahna.fi.intel.com>
References: <20160705012544.14143-1-paul.gortmaker@windriver.com>
 <20160705012544.14143-4-paul.gortmaker@windriver.com>
 <20160705100821.GK23527@lahna.fi.intel.com>
 <20160706163800.GH26134@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160706163800.GH26134@windriver.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 06, 2016 at 12:38:00PM -0400, Paul Gortmaker wrote:
> [Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular] On 05/07/2016 (Tue 13:08) Mika Westerberg wrote:
> 
> > On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote:
> > > The Kconfig currently controlling compilation of this code is:
> > > 
> > > drivers/mfd/Kconfig:config MFD_INTEL_MSIC
> > > drivers/mfd/Kconfig:    bool "Intel MSIC"
> > 
> > I would prefer if it could be turned to tristate instead. I don't see
> > any reasons why it should only be builtin.
> 
> If I change it to tristate, it is still impossible to choose =m for it
> unless I revert your earlier commit forcing it to be built in.
> 
> commit 15a713df4145ad2540f8d84c3f4de930806f6151
> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> Date:   Thu Jan 26 17:35:05 2012 +0000
> 
>     x86/config: Select MSIC MFD driver on Intel Medfield platform
>     
>     On Intel Medfield platform we use MSIC MFD driver to create
>     necessary platform devices so it is essential to have the driver
>     compiled into the kernel.
> 
> If I revert that, then it is possible to choose =m and it compiles.
> (haven't completed modpost yet.. so may be missing symbols...)

I think we can revert that and make it modular. Adding Andy just in case
I'm missing something obvious.