From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753418AbcGGLlG (ORCPT ); Thu, 7 Jul 2016 07:41:06 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33663 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbcGGLlE (ORCPT ); Thu, 7 Jul 2016 07:41:04 -0400 Date: Thu, 7 Jul 2016 13:41:01 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Dmitry Torokhov Cc: Hans de Goede , Ben Gamari , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Input: alps - cleanup Message-ID: <20160707114101.GS29844@pali> References: <1465212241-14702-1-git-send-email-pali.rohar@gmail.com> <20160621003113.GE22426@dtor-ws> <20160621112730.GU29844@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160621112730.GU29844@pali> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 21 June 2016 13:27:30 Pali Rohár wrote: > On Monday 20 June 2016 17:31:13 Dmitry Torokhov wrote: > > Hi Pali, > > > > On Mon, Jun 06, 2016 at 01:23:56PM +0200, Pali Rohár wrote: > > > This patch series cleanup usage of alps_model_data table. > > > > > > Pali Rohár (5): > > > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > > > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > > > Input: alps - move ALPS_PROTO_V1 out of alps_model_data table > > > Input: alps - warn about unsupported ALPS V9 touchpad > > > Input: alps - cleanup ALPS_PROTO_V2 detection > > > > Frankly, I do not quite like this series. The rule of thumb we had: if > > we can use e7 data to identify the device it should go into table, > > if we need to have more elaborate logic - then implement it in > > __alps_indentify(). I would understand if we got rid of the table > > completely, but we didn't. > > Hans and me agreed that alps_model_data array is for old touchpads > defined as quirks table. So in this patch series I'm trying to eliminate > using that array. And it is possible for V1, V4 and V6 touchpads because > each protocol has only one entry in table. And last user is just V2 > protocol which is I think better... > > So this is my motivation for this patch series. Any suggestion how to rework it? And any agreement if we should remove V1/V4/V6 from alps_model_date or let it stay here? > > I think the patch removing ALPS_PROTO_V4 and subsequent patch removing > > command_mode_resp from alps_model_info are good, the rest are not so > > much. > > > > Thanks. > > > -- Pali Rohár pali.rohar@gmail.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 0/5] Input: alps - cleanup Date: Thu, 7 Jul 2016 13:41:01 +0200 Message-ID: <20160707114101.GS29844@pali> References: <1465212241-14702-1-git-send-email-pali.rohar@gmail.com> <20160621003113.GE22426@dtor-ws> <20160621112730.GU29844@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:33663 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbcGGLlE (ORCPT ); Thu, 7 Jul 2016 07:41:04 -0400 Content-Disposition: inline In-Reply-To: <20160621112730.GU29844@pali> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Hans de Goede , Ben Gamari , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday 21 June 2016 13:27:30 Pali Roh=C3=A1r wrote: > On Monday 20 June 2016 17:31:13 Dmitry Torokhov wrote: > > Hi Pali, > >=20 > > On Mon, Jun 06, 2016 at 01:23:56PM +0200, Pali Roh=C3=A1r wrote: > > > This patch series cleanup usage of alps_model_data table. > > >=20 > > > Pali Roh=C3=A1r (5): > > > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > > > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > > > Input: alps - move ALPS_PROTO_V1 out of alps_model_data table > > > Input: alps - warn about unsupported ALPS V9 touchpad > > > Input: alps - cleanup ALPS_PROTO_V2 detection > >=20 > > Frankly, I do not quite like this series. The rule of thumb we had:= if > > we can use e7 data to identify the device it should go into table, > > if we need to have more elaborate logic - then implement it in > > __alps_indentify(). I would understand if we got rid of the table > > completely, but we didn't. >=20 > Hans and me agreed that alps_model_data array is for old touchpads > defined as quirks table. So in this patch series I'm trying to elimin= ate > using that array. And it is possible for V1, V4 and V6 touchpads beca= use > each protocol has only one entry in table. And last user is just V2 > protocol which is I think better... >=20 > So this is my motivation for this patch series. Any suggestion how to rework it? And any agreement if we should remove V1/V4/V6 from alps_model_date or let it stay here? > > I think the patch removing ALPS_PROTO_V4 and subsequent patch remov= ing > > command_mode_resp from alps_model_info are good, the rest are not s= o > > much. > >=20 > > Thanks. > >=20 >=20 --=20 Pali Roh=C3=A1r pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html