From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLRby-0003K7-TN for qemu-devel@nongnu.org; Fri, 08 Jul 2016 04:58:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLRbv-0002sK-BS for qemu-devel@nongnu.org; Fri, 08 Jul 2016 04:58:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLRbv-0002ru-5s for qemu-devel@nongnu.org; Fri, 08 Jul 2016 04:58:11 -0400 Date: Fri, 8 Jul 2016 09:58:07 +0100 From: "Daniel P. Berrange" Message-ID: <20160708085806.GB3205@redhat.com> Reply-To: "Daniel P. Berrange" References: <1467949056-81208-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1467949056-81208-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH] vnc: fix incorrect checking condition when updating client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org, kraxel@redhat.com, Haibin Wang On Fri, Jul 08, 2016 at 11:37:36AM +0800, Gonglei wrote: > vs->disconnecting is set to TRUE and vs->ioc is closed, but > vs->ioc isn't set to NULL, so that the vnc_disconnect_finish() > isn't invoked when you update client in vnc_update_client() > after vnc_disconnect_start invoked. Let's using change the checking > condition to avoid resource leak. > > Signed-off-by: Haibin Wang > Signed-off-by: Gonglei > --- > ui/vnc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|