From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754208AbcGHJVl (ORCPT ); Fri, 8 Jul 2016 05:21:41 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32831 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbcGHJVk (ORCPT ); Fri, 8 Jul 2016 05:21:40 -0400 Date: Fri, 8 Jul 2016 11:21:35 +0200 From: Ingo Molnar To: Borislav Petkov Cc: LKML , Aravind Gopalakrishnan , Yazen Ghannam Subject: Re: [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type Message-ID: <20160708092134.GA13849@gmail.com> References: <1467968983-4874-1-git-send-email-bp@alien8.de> <1467968983-4874-2-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467968983-4874-2-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > From: Aravind Gopalakrishnan > > Change bank_map type from char to int since we now have more than eight > banks in a system. > > Signed-off-by: Aravind Gopalakrishnan > Cc: Aravind Gopalakrishnan > Cc: Tony Luck > Cc: linux-edac > Link: http://lkml.kernel.org/r/1466462163-29008-1-git-send-email-Yazen.Ghannam@amd.com > Signed-off-by: Yazen Ghannam > Signed-off-by: Borislav Petkov > --- > arch/x86/kernel/cpu/mcheck/mce_amd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > index 10b0661651e0..7b7f3be783d4 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > @@ -93,7 +93,7 @@ const char * const amd_df_mcablock_names[] = { > EXPORT_SYMBOL_GPL(amd_df_mcablock_names); > > static DEFINE_PER_CPU(struct threshold_bank **, threshold_banks); > -static DEFINE_PER_CPU(unsigned char, bank_map); /* see which banks are on */ > +static DEFINE_PER_CPU(unsigned int, bank_map); /* see which banks are on */ Btw., is there any check somewhere which printed a helpful warning when we exceeded the 8 banks limit - and which would prints a helpful warning if we ever exceed the 32 banks limit? Thanks, Ingo