From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932401AbcGHJhr (ORCPT ); Fri, 8 Jul 2016 05:37:47 -0400 Received: from mail.skyhub.de ([78.46.96.112]:41883 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754603AbcGHJhe (ORCPT ); Fri, 8 Jul 2016 05:37:34 -0400 Date: Fri, 8 Jul 2016 11:37:31 +0200 From: Borislav Petkov To: Ingo Molnar Cc: LKML , Yazen Ghannam Subject: Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Message-ID: <20160708093731.GC3808@pd.tnic> References: <1467968983-4874-1-git-send-email-bp@alien8.de> <1467968983-4874-4-git-send-email-bp@alien8.de> <20160708092659.GB13849@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160708092659.GB13849@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 11:26:59AM +0200, Ingo Molnar wrote: > So why does neither the changelog nor the code comment actually _explain_ this and > give aa bit of a background about what 'syndrome information' is and why we want > to have kernel support for it? > > This is why I hate kernel tooling that is not part of the kernel tree - the mcelog > patch (hopefully ...) would tell us more about all this - but it's separate and > this patch does not tell us anything ... Ah, this is one of those omissions where we forgot to explain, sorry. How about this: "The syndrome value is used to uniquely identify which bits of a reported ECC error are corrupted." Do you want it as a comment in the code or in the commit message or both? Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.