From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582AbcGHKTs (ORCPT ); Fri, 8 Jul 2016 06:19:48 -0400 Received: from mga09.intel.com ([134.134.136.24]:14672 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932371AbcGHKTj (ORCPT ); Fri, 8 Jul 2016 06:19:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,329,1464678000"; d="scan'208";a="1003100872" Date: Fri, 8 Jul 2016 13:19:34 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: James Bottomley Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Message-ID: <20160708101934.GQ4329@intel.com> References: <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467919176.2322.38.camel@HansenPartnership.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 12:19:36PM -0700, James Bottomley wrote: > On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > > > Cc: Ville > > > > > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > > > Author: Ville Syrjälä > > > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel details > > > > > > > > > > > > > > After being more careful about waiting to identify flicker, > > > > > > > this one seems to be the one the bisect finds. I'm now > > > > > > > running v4.7-rc3 with this one reverted and am currently > > > > > > > seeing no flicker problems. It is, however, early days > > > > > > > because the flicker can hide for long periods, so I 'll > > > > > > > wait > > > > > > > until Monday evening and a few reboots before declaring > > > > > > > victory. > > > > > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > > > surprise me, and that in itself is depressing. > > > > > > > > > > As far as I can tell, after running for a day with this > > > > > reverted, > > > > > this is the problem. The flicker hasn't appeared with it > > > > > reverted. It's pretty noticeable with this commit included. > > > > > > > > Hmm. The only difference I can see is low vs. normal vswing. > > > > Panel > > > > 0 has low, panel 2 has normal. So either the VBT or opregion is > > > > telling utter lies, or there's some other bug in our low vswing > > > > support. > > > > > > I did a quick once over of out DDI vswing stuff and didn't find > > > anything too serious. There were some buglets in the iboost > > > handling, > > > but I'm not very hopeful that fixing those would help with your > > > machine. > > > > > > Here's a branch anyway in case you want to give it a go: > > > git://github.com/vsyrjala/linux.git ddi_iboost_fixes > > > > > > Actually, I think the only patch in there that might make a > > > difference is 15d887855180 ("drm/i915: Fix iboost setting for DDI > > > with 4 lanes on SKL") > > > > Running with it now (the entire branch). So far it looks OK, but > > I'll give it a couple of days to see if anything manifests before > > declaring victory. > > Bad news, I'm afraid: after a couple of hours of run time, there is now > noticeable flicker on the display, so although the iboost fixes may > have lessened it, it's still present. Oh well, I suspected as much. Which BIOS version did you have exactly? If I'm reading the Dell website correctly there's a new one (1.4.4) released on Jun 30, which is after you reported the issue. Might be I'm reading the wrong thing though. Can you double check this? -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Fri, 8 Jul 2016 13:19:34 +0300 Message-ID: <20160708101934.GQ4329@intel.com> References: <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1467919176.2322.38.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: James Bottomley Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdWwgMDcsIDIwMTYgYXQgMTI6MTk6MzZQTSAtMDcwMCwgSmFtZXMgQm90dG9tbGV5 IHdyb3RlOgo+IE9uIFRodSwgMjAxNi0wNy0wNyBhdCAwOTo1NSAtMDcwMCwgSmFtZXMgQm90dG9t bGV5IHdyb3RlOgo+ID4gT24gVGh1LCAyMDE2LTA3LTA3IGF0IDE5OjE0ICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgSnVuIDIxLCAyMDE2IGF0IDA2OjQ0OjM0UE0g KzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gPiBPbiBUdWUsIEp1biAyMSwgMjAx NiBhdCAwOTo1MzoxNUFNIC0wNDAwLCBKYW1lcyBCb3R0b21sZXkgd3JvdGU6Cj4gPiA+ID4gPiBP biBNb24sIDIwMTYtMDYtMjAgYXQgMTE6MDMgKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4g PiA+ID4gPiBDYzogVmlsbGUKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IE9uIE1vbiwgMjAgSnVu IDIwMTYsIEphbWVzIEJvdHRvbWxleSA8Cj4gPiA+ID4gPiA+IEphbWVzLkJvdHRvbWxleUBIYW5z ZW5QYXJ0bmVyc2hpcC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPiA+IE9LLCBteSBjYW5kaWRhdGUg YmFkIGNvbW1pdCBpcyB0aGlzIG9uZToKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBjb21t aXQgYTA1NjI4MTk1YTBkOWYzMTczZGQ5YWE3NmY0ODJhZWY2OTJlNDZlZQo+ID4gPiA+ID4gPiA+ IEF1dGhvcjogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiA+ID4gPiA+ID4gPiBEYXRlOiAgIE1vbiBBcHIgMTEgMTA6MjM6NTEgMjAxNiArMDMwMAo+ID4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ICAgICBkcm0vaTkxNTogR2V0IHBhbmVsX3R5cGUgZnJv bSBPcFJlZ2lvbiBwYW5lbCBkZXRhaWxzCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gQWZ0 ZXIgYmVpbmcgbW9yZSBjYXJlZnVsIGFib3V0IHdhaXRpbmcgdG8gaWRlbnRpZnkgZmxpY2tlciwK PiA+ID4gPiA+ID4gPiB0aGlzIG9uZSBzZWVtcyB0byBiZSB0aGUgb25lIHRoZSBiaXNlY3QgZmlu ZHMuICBJJ20gbm93IAo+ID4gPiA+ID4gPiA+IHJ1bm5pbmcgdjQuNy1yYzMgd2l0aCB0aGlzIG9u ZSByZXZlcnRlZCBhbmQgYW0gY3VycmVudGx5IAo+ID4gPiA+ID4gPiA+IHNlZWluZyBubyBmbGlj a2VyIHByb2JsZW1zLiAgIEl0IGlzLCBob3dldmVyLCBlYXJseSBkYXlzIAo+ID4gPiA+ID4gPiA+ IGJlY2F1c2UgdGhlIGZsaWNrZXIgY2FuIGhpZGUgZm9yIGxvbmcgcGVyaW9kcywgc28gSSAnbGwK PiA+ID4gPiA+ID4gPiB3YWl0IAo+ID4gPiA+ID4gPiA+IHVudGlsIE1vbmRheSBldmVuaW5nIGFu ZCBhIGZldyByZWJvb3RzIGJlZm9yZSBkZWNsYXJpbmcKPiA+ID4gPiA+ID4gPiB2aWN0b3J5Lgo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gSWYgdGhhdCB0dXJucyBvdXQgdG8gYmUgdGhlIGJhZCBj b21taXQsIGl0IGRvZXNuJ3QgcmVhbGx5IAo+ID4gPiA+ID4gPiBzdXJwcmlzZSBtZSwgYW5kIHRo YXQgaW4gaXRzZWxmIGlzIGRlcHJlc3NpbmcuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFzIGZhciBh cyBJIGNhbiB0ZWxsLCBhZnRlciBydW5uaW5nIGZvciBhIGRheSB3aXRoIHRoaXMKPiA+ID4gPiA+ IHJldmVydGVkLCAKPiA+ID4gPiA+IHRoaXMgaXMgdGhlIHByb2JsZW0uICBUaGUgZmxpY2tlciBo YXNuJ3QgYXBwZWFyZWQgd2l0aCBpdCAKPiA+ID4gPiA+IHJldmVydGVkLiAgSXQncyBwcmV0dHkg bm90aWNlYWJsZSB3aXRoIHRoaXMgY29tbWl0IGluY2x1ZGVkLgo+ID4gPiA+IAo+ID4gPiA+IEht bS4gVGhlIG9ubHkgZGlmZmVyZW5jZSBJIGNhbiBzZWUgaXMgbG93IHZzLiBub3JtYWwgdnN3aW5n Lgo+ID4gPiA+IFBhbmVsIAo+ID4gPiA+IDAgaGFzIGxvdywgcGFuZWwgMiBoYXMgbm9ybWFsLiBT byBlaXRoZXIgdGhlIFZCVCBvciBvcHJlZ2lvbiBpcyAKPiA+ID4gPiB0ZWxsaW5nIHV0dGVyIGxp ZXMsIG9yIHRoZXJlJ3Mgc29tZSBvdGhlciBidWcgaW4gb3VyIGxvdyB2c3dpbmcKPiA+ID4gPiBz dXBwb3J0Lgo+ID4gPiAKPiA+ID4gSSBkaWQgYSBxdWljayBvbmNlIG92ZXIgb2Ygb3V0IERESSB2 c3dpbmcgc3R1ZmYgYW5kIGRpZG4ndCBmaW5kIAo+ID4gPiBhbnl0aGluZyB0b28gc2VyaW91cy4g VGhlcmUgd2VyZSBzb21lIGJ1Z2xldHMgaW4gdGhlIGlib29zdAo+ID4gPiBoYW5kbGluZywgCj4g PiA+IGJ1dCBJJ20gbm90IHZlcnkgaG9wZWZ1bCB0aGF0IGZpeGluZyB0aG9zZSB3b3VsZCBoZWxw IHdpdGggeW91ciAKPiA+ID4gbWFjaGluZS4gCj4gPiA+IAo+ID4gPiBIZXJlJ3MgYSBicmFuY2gg YW55d2F5IGluIGNhc2UgeW91IHdhbnQgdG8gZ2l2ZSBpdCBhIGdvOgo+ID4gPiBnaXQ6Ly9naXRo dWIuY29tL3ZzeXJqYWxhL2xpbnV4LmdpdCBkZGlfaWJvb3N0X2ZpeGVzCj4gPiA+IAo+ID4gPiBB Y3R1YWxseSwgSSB0aGluayB0aGUgb25seSBwYXRjaCBpbiB0aGVyZSB0aGF0IG1pZ2h0IG1ha2Ug YSAKPiA+ID4gZGlmZmVyZW5jZSBpcyAxNWQ4ODc4NTUxODAgKCJkcm0vaTkxNTogRml4IGlib29z dCBzZXR0aW5nIGZvciBEREkgCj4gPiA+IHdpdGggNCBsYW5lcyBvbiBTS0wiKQo+ID4gCj4gPiBS dW5uaW5nIHdpdGggaXQgbm93ICh0aGUgZW50aXJlIGJyYW5jaCkuICBTbyBmYXIgaXQgbG9va3Mg T0ssIGJ1dCAKPiA+IEknbGwgZ2l2ZSBpdCBhIGNvdXBsZSBvZiBkYXlzIHRvIHNlZSBpZiBhbnl0 aGluZyBtYW5pZmVzdHMgYmVmb3JlCj4gPiBkZWNsYXJpbmcgdmljdG9yeS4KPiAKPiBCYWQgbmV3 cywgSSdtIGFmcmFpZDogYWZ0ZXIgYSBjb3VwbGUgb2YgaG91cnMgb2YgcnVuIHRpbWUsIHRoZXJl IGlzIG5vdwo+IG5vdGljZWFibGUgZmxpY2tlciBvbiB0aGUgZGlzcGxheSwgc28gYWx0aG91Z2gg dGhlIGlib29zdCBmaXhlcyBtYXkKPiBoYXZlIGxlc3NlbmVkIGl0LCBpdCdzIHN0aWxsIHByZXNl bnQuCgpPaCB3ZWxsLCBJIHN1c3BlY3RlZCBhcyBtdWNoLiBXaGljaCBCSU9TIHZlcnNpb24gZGlk IHlvdSBoYXZlIGV4YWN0bHk/CklmIEknbSByZWFkaW5nIHRoZSBEZWxsIHdlYnNpdGUgY29ycmVj dGx5IHRoZXJlJ3MgYSBuZXcgb25lICgxLjQuNCkKcmVsZWFzZWQgb24gSnVuIDMwLCB3aGljaCBp cyBhZnRlciB5b3UgcmVwb3J0ZWQgdGhlIGlzc3VlLiBNaWdodCBiZQpJJ20gcmVhZGluZyB0aGUg d3JvbmcgdGhpbmcgdGhvdWdoLiBDYW4geW91IGRvdWJsZSBjaGVjayB0aGlzPwoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==