From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755395AbcGHOsX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 10:48:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38526 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754945AbcGHOsS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 10:48:18 -0400
Date: Fri, 8 Jul 2016 16:48:14 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org,
        pi3orama@163.com, He Kuang <hekuang@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Nilay Vaish <nilayvaish@gmail.com>
Subject: Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for
 overwritable events
Message-ID: <20160708144814.GB31763@krava>
References: <1467869689-214015-1-git-send-email-wangnan0@huawei.com>
 <1467869689-214015-5-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467869689-214015-5-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 08 Jul 2016 14:48:17 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2016 at 05:34:45AM +0000, Wang Nan wrote:

SNIP

> +	if (err)
> +		return err;
> +
> +	err = record__mmap_evlist(rec, rec->evlist, false);
> +	if (err)
> +		return err;
> +
> +	if (!rec->overwrite_evlist)
> +		return 0;
> +
> +	err = record__mmap_evlist(rec, rec->overwrite_evlist, true);
> +	if (err)
> +		return err;
> +	return 0;
>  }
>  
>  static int record__open(struct record *rec)
> @@ -698,9 +743,14 @@ static const struct perf_event_mmap_page *record__pick_pc(struct record *rec)
>  {
>  	const struct perf_event_mmap_page *pc;
>  
> +	/* Change it to a loop if a new aux evlist is added */
>  	pc = perf_evlist__pick_pc(rec->evlist);
>  	if (pc)
>  		return pc;
> +	pc = perf_evlist__pick_pc(rec->overwrite_evlist);
> +	if (pc)
> +		return pc;
> +
>  	return NULL;

above 4 lines could be just:

	return perf_evlist__pick_pc(rec->overwrite_evlist);


jirka