From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757228AbcGJPQx (ORCPT ); Sun, 10 Jul 2016 11:16:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59503 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757170AbcGJPQv (ORCPT ); Sun, 10 Jul 2016 11:16:51 -0400 Date: Sun, 10 Jul 2016 23:16:46 +0800 From: Baoquan He To: Ingo Molnar Cc: peterz@infradead.org, hpa@zytor.com, keescook@chromium.org, xiaolong.ye@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/boot] x86/KASLR: Fix boot crash with certain memory configurations Message-ID: <20160710151646.GB2512@x1.redhat.com> References: <20160710090953.GA2512@x1.redhat.com> <20160710112427.GA16729@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160710112427.GA16729@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 10 Jul 2016 15:16:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/16 at 01:24pm, Ingo Molnar wrote: > > * Baoquan He wrote: > > > Hi Ingo, > > > > I am sorry the previous post didn't contain formal patch log. I made a new one > > as below. The boot crash could not only happen with certain memory. Because of > > this code bug the regions which need be avoided like the zipped kernel with its > > unzipping running code, initrd, kernel command line could be corrupted if > > mem_avoid_overlap() can't find the overlap region with the lowest address. But > > it's very lucky that Xiaolong's system which has only 300M memory can always > > reproduce it. I checked the boog log and found on his system no any other slot > > can be chosen except for the original one. If we have a system with large memory > > it may not be easy to hit it, at least with low probability since there are many > > candidate slots. > > So if it's just a better changelog that what I wrote I wouldn't rebase the commit: > there's other commits on top of the fix meanwhile. Should a rebase become > necessary at a later point I'll update it with your extended changelog. Yes, it's just a changelog update, no need to rebase it now. Thanks Baoquan