From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio
 entry
Date: Sun, 10 Jul 2016 22:37:51 +0200
Message-ID: <20160710203751.GB26397@lunn.ch>
References: <E1bMGdu-00005c-Dy@rmk-PC.armlinux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <E1bMGdu-00005c-Dy-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Jon Nettleton <jon-UBr1pzP51AyaMJb+Lgu22Q@public.gmane.org>, Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: devicetree@vger.kernel.org

On Sun, Jul 10, 2016 at 04:27:38PM +0100, Russell King wrote:
> The clearfog DTS should not be defining the on-board phy, this device
> is located on the microsom.  Remove the duplicated definition.

Hi Russell

While reviewing this patch i noticed that the microsom .dtsi file has

                        pinctrl@18000 {
                                microsom_phy_clk_pins: microsom-phy-clk-pins {
                                        marvell,pins = "mpp45";
                                        marvell,function = "ref";
                                };
                        };

The armada-38x.dtsi has

                                ref_clk0_pins: ref-clk-pins-0 {
                                        marvell,pins = "mpp45";
                                        marvell,function = "ref";
                                };

which you could reference rather then defining it yourself.

      Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From mboxrd@z Thu Jan  1 00:00:00 1970
From: andrew@lunn.ch (Andrew Lunn)
Date: Sun, 10 Jul 2016 22:37:51 +0200
Subject: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry
In-Reply-To: <E1bMGdu-00005c-Dy@rmk-PC.armlinux.org.uk>
References: <E1bMGdu-00005c-Dy@rmk-PC.armlinux.org.uk>
Message-ID: <20160710203751.GB26397@lunn.ch>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Sun, Jul 10, 2016 at 04:27:38PM +0100, Russell King wrote:
> The clearfog DTS should not be defining the on-board phy, this device
> is located on the microsom.  Remove the duplicated definition.

Hi Russell

While reviewing this patch i noticed that the microsom .dtsi file has

                        pinctrl at 18000 {
                                microsom_phy_clk_pins: microsom-phy-clk-pins {
                                        marvell,pins = "mpp45";
                                        marvell,function = "ref";
                                };
                        };

The armada-38x.dtsi has

                                ref_clk0_pins: ref-clk-pins-0 {
                                        marvell,pins = "mpp45";
                                        marvell,function = "ref";
                                };

which you could reference rather then defining it yourself.

      Andrew