From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry Date: Mon, 11 Jul 2016 00:53:59 +0200 Message-ID: <20160710225359.GO8426@lunn.ch> References: <20160710203751.GB26397@lunn.ch> <20160710204546.GS1041@n2100.armlinux.org.uk> <20160710222743.GN8426@lunn.ch> <20160710223804.GT1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160710223804.GT1041-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux Cc: Jason Cooper , Jon Nettleton , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Jul 10, 2016 at 11:38:04PM +0100, Russell King - ARM Linux wrote: > On Mon, Jul 11, 2016 at 12:27:43AM +0200, Andrew Lunn wrote: > > On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote: > > > On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote: > > > > The armada-38x.dtsi has > > > > > > > > ref_clk0_pins: ref-clk-pins-0 { > > > > marvell,pins = "mpp45"; > > > > marvell,function = "ref"; > > > > }; > > > > > > > > which you could reference rather then defining it yourself. > > > > > > Weren't these going to be deleted from the main SoC dtsi files, > > > eventually? I thought that was the idea, to prevent cluttering > > > up the .dtb files with nodes which aren't ever used. > > > > I've not heard they are going to be removed.... > > > > Having work on mvebu, and a Freescale Vybrid board, i see two > > different styles. mvebu defines all the common pinctrl values in the > > .dtsi file, so making the .dts file pretty minimalist. For the vybrid > > board there was nothing in the .dtsi file, the dts file is huge, and i > > made at least one error, missing at required pin which took me a while > > to debug. > > > > I would also say cluttered .dtb because of unused nodes it a compiler > > issue. Why does it not optimise them out? > > How does it know that the pinmux nodes (which are nodes in their own > right, just like any node specifying a real device) are "unused" ? Yes, you are right. A phandle pointing to it shows it is used, but not being references via a phandle does not mean it is unused. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Mon, 11 Jul 2016 00:53:59 +0200 Subject: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry In-Reply-To: <20160710223804.GT1041@n2100.armlinux.org.uk> References: <20160710203751.GB26397@lunn.ch> <20160710204546.GS1041@n2100.armlinux.org.uk> <20160710222743.GN8426@lunn.ch> <20160710223804.GT1041@n2100.armlinux.org.uk> Message-ID: <20160710225359.GO8426@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jul 10, 2016 at 11:38:04PM +0100, Russell King - ARM Linux wrote: > On Mon, Jul 11, 2016 at 12:27:43AM +0200, Andrew Lunn wrote: > > On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote: > > > On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote: > > > > The armada-38x.dtsi has > > > > > > > > ref_clk0_pins: ref-clk-pins-0 { > > > > marvell,pins = "mpp45"; > > > > marvell,function = "ref"; > > > > }; > > > > > > > > which you could reference rather then defining it yourself. > > > > > > Weren't these going to be deleted from the main SoC dtsi files, > > > eventually? I thought that was the idea, to prevent cluttering > > > up the .dtb files with nodes which aren't ever used. > > > > I've not heard they are going to be removed.... > > > > Having work on mvebu, and a Freescale Vybrid board, i see two > > different styles. mvebu defines all the common pinctrl values in the > > .dtsi file, so making the .dts file pretty minimalist. For the vybrid > > board there was nothing in the .dtsi file, the dts file is huge, and i > > made at least one error, missing at required pin which took me a while > > to debug. > > > > I would also say cluttered .dtb because of unused nodes it a compiler > > issue. Why does it not optimise them out? > > How does it know that the pinmux nodes (which are nodes in their own > right, just like any node specifying a real device) are "unused" ? Yes, you are right. A phandle pointing to it shows it is used, but not being references via a phandle does not mean it is unused. Andrew