All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org, 会社ぴか <akira.yokosawa@toshiba.co.jp>
Subject: Re: [GIT PULL] Cosmetic fixes round 3 and other fixes
Date: Sun, 10 Jul 2016 16:22:36 -0700	[thread overview]
Message-ID: <20160710232236.GB4650@linux.vnet.ibm.com> (raw)
In-Reply-To: <bd5ad965-7472-494c-ff18-0bb6a1ed00af@gmail.com>

On Mon, Jul 11, 2016 at 08:01:23AM +0900, Akira Yokosawa wrote:
> On 2016/07/10 08:35:02 -0700, Paul E. McKenney wrote:
> >On Mon, Jul 11, 2016 at 12:08:11AM +0900, Akira Yokosawa wrote:
> >>On 2016/07/10 23:41, Paul E. McKenney wrote:
> >>>On Sat, Jul 09, 2016 at 03:24:51PM +0900, Akira Yokosawa wrote:
> >>>>Hi Paul,
> >>>>
> >>>>Today, because of the weather, I have time to do clean up the cosmetic
> >>>>fixes. Appended are two pull requests.
> >>>
> >>>Very good!  I pulled both and pushed them out.  I made a small change
> >>>to the label for the table that you (rightly) changed to a figure,
> >>>so that it is prefixed by "tab:" rather than "fig:".
> >>>
> >>
> >>Oh, I missed those labels...
> >>
> >>So, I reviewed latex source of recently added figures.
> >>You are still using 'center' environment within 'figure' environment.
> >>That will cause extra small vertical spacing between the body of the
> >>figure and its caption.
> >>
> >>In stead of doing such as:
> >>
> >>\begin{figure}[tb]
> >>\begin{center}
> >>\resizebox{{2.5in}{!}{\includegraphics{path-to-figure}}
> >>\end{center}
> >>\caption{foo bar}
> >>\label{fig:foo bar}
> >>\end{figure}
> >>
> >>please do this way:
> >>
> >>\begin{figure}[tb]
> >>\centering
> >>\resizebox{{2.5in}{!}{\includegraphics{path-to-figure}}
> >>\caption{foo bar}
> >>\label{fig:foo bar}
> >>\end{figure}
> >
> >I fixed the one that I added to defer/refcnt.tex, good catch.
> >
> >>Also, there are templates in ".Templates/figure-graphics" that
> >>use the 'center' environment. They should also be fixed to use
> >>\centering instead.
> >
> >Actually, unless you have objections, I intend to remove them.  My
> >practice for a long time has been to copy existing figures.  In fact,
> >I had forgotten that the .Template directory even existed.  ;-)
> 
> I found the template by using emacs' 'grep-find' function.
> So feel free to remove them.
> 
> There remains one use of 'center' environment in
> /advsync/memorybarriers.tex.
> I left it as is since it is not nested in another environment.
> 
> But it might be a good idea to promote it to a full-fledged figure with
> a caption. It's up to your preference.

There are a number of minipage environments that might want to be
figures.  But there are so many of them in some places that latex's
figure-placement algorithm gets overwhelmed.

> And there is another suggestion I'd like to make.
> 
> Wouldn't it be a good idea to advertize the cross-link feature of qqz
> somewhere, for example in the Answer of Quick Quick 1.3?

Like this?

							Thanx, Paul

------------------------------------------------------------------------

commit 22f83a69d5dd496456b3975c5482b20af002927a
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date:   Sun Jul 10 16:20:22 2016 -0700

    Add instructions on using quick-quiz hyperlinks
    
    Reported-by: Akira Yokosawa <akiyks@gmail.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/howto/howto.tex b/howto/howto.tex
index 7c6ef9de4739..177395fc85ca 100644
--- a/howto/howto.tex
+++ b/howto/howto.tex
@@ -206,6 +206,12 @@ Here are a few possible strategies:
 	expect to be called upon to generate parallel solutions given
 	only a blank sheet of paper.
 \end{enumerate}
+
+Note that as of mid-2016 the quick quizzes are hyperlinked
+to the answer and vice versa, courtesy of Paolo Bonzini
+and Akira Yokosawa.
+Click either the ``Quick Quiz'' headings or the small squares
+to move back and forth between quiz and answer.
 } \QuickQuizEnd

 In short, if you need a deep


  reply	other threads:[~2016-07-10 23:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09  6:24 [GIT PULL] Cosmetic fixes round 3 and other fixes Akira Yokosawa
2016-07-10 14:41 ` Paul E. McKenney
2016-07-10 15:08   ` Akira Yokosawa
2016-07-10 15:35     ` Paul E. McKenney
2016-07-10 23:01       ` Akira Yokosawa
2016-07-10 23:22         ` Paul E. McKenney [this message]
2016-07-11 11:55           ` Akira Yokosawa
2016-07-11 13:52             ` Paul E. McKenney
2016-07-11 14:32               ` Akira Yokosawa
2016-07-11 15:37                 ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160710232236.GB4650@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akira.yokosawa@toshiba.co.jp \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.