From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757443AbcGKBDg (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Jul 2016 21:03:36 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:40590 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751406AbcGKBDf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Jul 2016 21:03:35 -0400
Date: Mon, 11 Jul 2016 02:03:32 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: James Simmons <jsimmons@infradead.org>
Cc: Oleg Drokin <green@linuxhacker.ru>,
        Mailing List <linux-kernel@vger.kernel.org>,
        "<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Subject: Re: More parallel atomic_open/d_splice_alias fun with NFS and
 possibly more FSes.
Message-ID: <20160711010332.GV14480@ZenIV.linux.org.uk>
References: <FCD75A55-A1BE-48FD-8E90-E9DFFD4DFD99@linuxhacker.ru>
 <20160703062917.GG14480@ZenIV.linux.org.uk>
 <20160704000802.GH14480@ZenIV.linux.org.uk>
 <0145470E-667E-4A8D-AB79-F897322DA441@linuxhacker.ru>
 <20160704030812.GI14480@ZenIV.linux.org.uk>
 <1CFAE5F0-5E46-4B1D-A9EC-2D6286753A35@linuxhacker.ru>
 <20160705022556.GK14480@ZenIV.linux.org.uk>
 <88A6EDE1-10F4-48FA-BCDC-D507C3E22DFA@linuxhacker.ru>
 <alpine.LFD.2.20.1607101913170.6483@casper.infradead.org>
 <20160711010113.GU14480@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160711010113.GU14480@ZenIV.linux.org.uk>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 11, 2016 at 02:01:13AM +0100, Al Viro wrote:
> On Sun, Jul 10, 2016 at 07:14:18PM +0100, James Simmons wrote:
> 
> > [  111.210818]  [<ffffffffa04012bd>] kiblnd_send+0x51d/0x9e0 [ko2iblnd]
> 
> Mea culpa - in kiblnd_send() this
>         if (payload_kiov)
>                 iov_iter_bvec(&from, ITER_BVEC | WRITE,
>                                 payload_kiov, payload_niov, payload_nob);
>         else
>                 iov_iter_kvec(&from, ITER_BVEC | WRITE,
>                                 payload_iov, payload_niov, payload_nob);
> should have s/BVEC/KVEC/ in the iov_iter_kvec() arguments.  Cut'n'paste
> braindamage...

PS: That was introduced in the last commit in that pile - "lustre: introduce
lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov()".