From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933668AbcGKG4d (ORCPT ); Mon, 11 Jul 2016 02:56:33 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33812 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757728AbcGKG42 (ORCPT ); Mon, 11 Jul 2016 02:56:28 -0400 Date: Mon, 11 Jul 2016 14:48:45 +0800 From: Peter Chen To: Rajesh Bhagat Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peter.Chen@nxp.com, gregkh@linuxfoundation.org, kishon@ti.com, robh+dt@kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Message-ID: <20160711064845.GH31647@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > Describes the qoriq usb 2.0 controller driver binding, currently used > for LS1021A and LS1012A platform. > > Signed-off-by: Rajesh Bhagat > --- > Changes in v2: > - Adds DT binding documentation for qoriq usb 2.0 controller > - Changed the compatible string to fsl,ci-qoriq-usb2 > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > new file mode 100644 > index 0000000..8ad7306 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > @@ -0,0 +1,34 @@ > +* Freescale QorIQ SoC USB 2.0 Controllers > + > +Required properties: > +- compatible: Should be "fsl,ci-qoriq-usb2" > + Wherever applicable, the IP version of the USB controller should > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > + where, X.Y is IP version of USB controller. Why you need to add IP version at compatible string? Does it can't be read out from ID register of Identification Registers. > +- reg: Should contain registers location and length > +- interrupts: Should contain controller interrupt > +- phy-names: from the *Generic PHY* bindings > +- phys: from the *Generic PHY* bindings > +- clocks: clock provider specifier > +- clock-names: shall be "usb2-clock" > +Refer to clk/clock-bindings.txt for generic clock consumer properties > + > +Recommended properties: > +- dr_mode: One of "host" or "peripheral". Do you support dual-role? > +- phy_type: the type of the phy connected to the core. Should be one > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this > + property the PORTSC register won't be touched > + > +Examples: > +usb@8600000 { > + compatible = "fsl,ci-qoriq-usb2", > + "fsl,ci-qoriq-usb2-v2.5"; > + reg = <0x0 0x8600000 0x0 0x1000>; > + interrupts = <0 139 0x4>; > + phy-names = "usb2-phy"; > + phys = <&usbphy0>; > + clock-names = "usb2-clock"; > + clocks = <&clockgen 4 3>; > + dr_mode = "host"; > + phy_type = "ulpi"; > +}; > -- > 2.6.2.198.g614a2ac > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: hzpeterchen@gmail.com (Peter Chen) Date: Mon, 11 Jul 2016 14:48:45 +0800 Subject: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller In-Reply-To: <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> Message-ID: <20160711064845.GH31647@shlinux2> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > Describes the qoriq usb 2.0 controller driver binding, currently used > for LS1021A and LS1012A platform. > > Signed-off-by: Rajesh Bhagat > --- > Changes in v2: > - Adds DT binding documentation for qoriq usb 2.0 controller > - Changed the compatible string to fsl,ci-qoriq-usb2 > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > new file mode 100644 > index 0000000..8ad7306 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > @@ -0,0 +1,34 @@ > +* Freescale QorIQ SoC USB 2.0 Controllers > + > +Required properties: > +- compatible: Should be "fsl,ci-qoriq-usb2" > + Wherever applicable, the IP version of the USB controller should > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > + where, X.Y is IP version of USB controller. Why you need to add IP version at compatible string? Does it can't be read out from ID register of Identification Registers. > +- reg: Should contain registers location and length > +- interrupts: Should contain controller interrupt > +- phy-names: from the *Generic PHY* bindings > +- phys: from the *Generic PHY* bindings > +- clocks: clock provider specifier > +- clock-names: shall be "usb2-clock" > +Refer to clk/clock-bindings.txt for generic clock consumer properties > + > +Recommended properties: > +- dr_mode: One of "host" or "peripheral". Do you support dual-role? > +- phy_type: the type of the phy connected to the core. Should be one > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this > + property the PORTSC register won't be touched > + > +Examples: > +usb at 8600000 { > + compatible = "fsl,ci-qoriq-usb2", > + "fsl,ci-qoriq-usb2-v2.5"; > + reg = <0x0 0x8600000 0x0 0x1000>; > + interrupts = <0 139 0x4>; > + phy-names = "usb2-phy"; > + phys = <&usbphy0>; > + clock-names = "usb2-clock"; > + clocks = <&clockgen 4 3>; > + dr_mode = "host"; > + phy_type = "ulpi"; > +}; > -- > 2.6.2.198.g614a2ac > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen