From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Steve Glendinning <steve.glendinning@smsc.com>,
Guenter Roeck <linux@roeck-us.net>,
Jeremy Linton <jeremy.linton@arm.com>,
Kamlakant Patel <kamlakant.patel@broadcom.com>,
Pavel Fedin <p.fedin@samsung.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
John Stultz <john.stultz@linaro.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support
Date: Mon, 11 Jul 2016 01:14:52 -0700 [thread overview]
Message-ID: <20160711081451.GX28305@atomide.com> (raw)
In-Reply-To: <1467968852-6175-3-git-send-email-linus.walleij@linaro.org>
* Linus Walleij <linus.walleij@linaro.org> [160708 02:10]:
> The SMSC911x have a line out of the chip called "PME",
> Power Management Event. When connected to an asynchronous
> interrupt controller this is able to wake the system up
> from sleep in response to certain network events.
Cool, so far have not found any boards here with that
connected. Should be possible to solder that on at least
omap3-evm at some point though.
> +static irqreturn_t smsc911x_pme_irq_thread(int irq, void *dev_id)
> +{
> + struct net_device *dev = dev_id;
> + struct smsc911x_data *pdata __maybe_unused = netdev_priv(dev);
> +
> + SMSC_TRACE(pdata, pm, "wakeup event");
> + /* This signal is active for 50 ms, wait for it to deassert */
> + usleep_range(50000, 100000);
> + return IRQ_HANDLED;
> +}
This probably adds an extra 50 ms latency before we wake up
the smsc911x driver. Maybe we can eventually come up with
some nice solution to that too. Anyways, no objections on
my side for this patch as it provides a nice GPIO wakeirq test
case that can be automated with just ping -c 1 :)
Regards,
Tony
next prev parent reply other threads:[~2016-07-11 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:07 [PATCH 1/3] net: smsc911x: augment device tree bindings Linus Walleij
2016-07-08 9:07 ` [PATCH 2/3] net: smsc911x: request and deassert optional RESET GPIO Linus Walleij
2016-07-08 13:52 ` Guenter Roeck
2016-07-08 9:07 ` [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support Linus Walleij
2016-07-11 8:14 ` Tony Lindgren [this message]
2016-07-11 10:23 ` Sudeep Holla
2016-07-15 19:13 ` Florian Fainelli
2016-07-15 19:03 ` [PATCH 1/3] net: smsc911x: augment device tree bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711081451.GX28305@atomide.com \
--to=tony@atomide.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=davem@davemloft.net \
--cc=jeremy.linton@arm.com \
--cc=john.stultz@linaro.org \
--cc=kamlakant.patel@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=steve.glendinning@smsc.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.