From: Herbert Xu <herbert@gondor.apana.org.au>
To: Will Thomas <will.thomas@imgtec.com>
Cc: linux-crypto@vger.kernel.org, will.thomas@imgtec.com
Subject: Re: [PATCH 1/6] crypto: img-hash - Fix null pointer exception
Date: Tue, 12 Jul 2016 15:41:01 +0800 [thread overview]
Message-ID: <20160712074101.GA29651@gondor.apana.org.au> (raw)
In-Reply-To: <1468229616-3888-2-git-send-email-will.thomas@imgtec.com>
Will Thomas <will.thomas@imgtec.com> wrote:
> Sporadic null pointer exceptions came from here. Fix them.
>
> Signed-off-by: Will Thomas <will.thomas@imgtec.com>
> Reviewed-by: James Hartley <james.hartley@imgtec.com>
> ---
> drivers/crypto/img-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
> index 68e8aa9..a5f270b 100644
> --- a/drivers/crypto/img-hash.c
> +++ b/drivers/crypto/img-hash.c
> @@ -361,7 +361,7 @@ static void img_hash_dma_task(unsigned long d)
> size_t nbytes, bleft, wsend, len, tbc;
> struct scatterlist tsg;
>
> - if (!ctx->sg)
> + if (!ctx || !ctx->sg)
> return;
This makes no sense. ctx comes from ahash_request_ctx which can
never be NULL. Perhaps you meant !hdev->req?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-07-12 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 9:33 [PATCH 0/6] crypto: img-hash - fixes and interface changes Will Thomas
2016-07-11 9:33 ` [PATCH 1/6] crypto: img-hash - Fix null pointer exception Will Thomas
2016-07-12 7:41 ` Herbert Xu [this message]
2016-07-11 9:33 ` [PATCH 2/6] crypto: img-hash - Fix hash request context Will Thomas
2016-07-12 7:43 ` Herbert Xu
2016-07-13 14:45 ` Will Thomas
2016-07-11 9:33 ` [PATCH 3/6] crypto: img-hash - Reconfigure DMA Burst length Will Thomas
2016-07-11 9:33 ` [PATCH 4/6] crypto: img-hash - Add suspend resume hooks for img hash Will Thomas
2016-07-11 9:33 ` [PATCH 5/6] crypto: img-hash - Add support for export and import Will Thomas
2016-07-12 7:49 ` Herbert Xu
2016-07-13 14:01 ` Will Thomas
2016-07-18 6:13 ` Herbert Xu
2016-07-11 9:33 ` [PATCH 6/6] crypto: img-hash - log a successful probe Will Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712074101.GA29651@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=will.thomas@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.