All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	David Weinehall <david.weinehall@intel.com>
Subject: Re: [PATCH] drm/i915: Fill unused GGTT with scratch pages for VT-d
Date: Tue, 12 Jul 2016 09:59:53 +0100	[thread overview]
Message-ID: <20160712085953.GM6157@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1468313426.5866.1.camel@linux.intel.com>

On Tue, Jul 12, 2016 at 11:50:26AM +0300, Joonas Lahtinen wrote:
> On pe, 2016-06-24 at 14:07 +0100, Chris Wilson wrote:
> > One of the numerous VT-d workarounds we require is that the display
> > hardware reads past the end of the buffer triggering VT-d faults. This
> > is acknowledged in the code as being safe "since we fill the unused
> > portions of the GGTT with the scratch page". Alas, that is no longer
> > always true and so we trigger DMAR read faults.
> > 
> > Skylake also requires another workaround to avoid mixing VT-d and
> > unpopulated PTE, and so there we also need to ensure we fill unused
> > entries with the scratch page.
> 
> Rather agressive W/A for just scanout, so maybe drop the scanout word?

The original w/a was just for VT'd + scanout, I was thinking of a
comment, but it never materialised.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-07-12  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 13:07 [PATCH] drm/i915: Fill unused GGTT with scratch pages for VT-d Chris Wilson
2016-06-24 14:47 ` ✓ Ro.CI.BAT: success for " Patchwork
2016-07-08 12:02 ` [PATCH] " Chris Wilson
2016-07-08 12:29 ` David Weinehall
2016-07-08 12:39   ` Chris Wilson
2016-07-12  8:50 ` Joonas Lahtinen
2016-07-12  8:59   ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712085953.GM6157@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=david.weinehall@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.