From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbcGMNQs (ORCPT ); Wed, 13 Jul 2016 09:16:48 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:52300 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbcGMNQk (ORCPT ); Wed, 13 Jul 2016 09:16:40 -0400 Date: Wed, 13 Jul 2016 09:15:55 -0400 From: Johannes Weiner To: Mel Gorman Cc: Andrew Morton , Linux-MM , Minchan Kim , LKML Subject: Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Message-ID: <20160713131555.GE9905@cmpxchg.org> References: <1468404004-5085-1-git-send-email-mgorman@techsingularity.net> <1468404004-5085-4-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468404004-5085-4-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 11:00:03AM +0100, Mel Gorman wrote: > From: Minchan Kim > > Note from Mel: This may optionally be considered a fix to the mmotm patch > mm-page_alloc-consider-dirtyable-memory-in-terms-of-nodes.patch > but if so, please preserve credit for Minchan. > > When I tested vmscale in mmtest in 32bit, I found the benchmark was slow > down 0.5 times. > > base node > 1 global-1 > User 12.98 16.04 > System 147.61 166.42 > Elapsed 26.48 38.08 > > With vmstat, I found IO wait avg is much increased compared to base. > > The reason was highmem_dirtyable_memory accumulates free pages and > highmem_file_pages from HIGHMEM to MOVABLE zones which was wrong. With > that, dirth_thresh in throtlle_vm_write is always 0 so that it calls > congestion_wait frequently if writeback starts. > > With this patch, it is much recovered. > > base node fi > 1 global-1 fix > User 12.98 16.04 13.78 > System 147.61 166.42 143.92 > Elapsed 26.48 38.08 29.64 > > Signed-off-by: Minchan Kim > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id 80CFE6B0253 for ; Wed, 13 Jul 2016 09:16:01 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id x83so34840110wma.2 for ; Wed, 13 Jul 2016 06:16:01 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id 16si27936786wmb.72.2016.07.13.06.16.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jul 2016 06:16:00 -0700 (PDT) Date: Wed, 13 Jul 2016 09:15:55 -0400 From: Johannes Weiner Subject: Re: [PATCH 3/4] mm, page_alloc: fix dirtyable highmem calculation Message-ID: <20160713131555.GE9905@cmpxchg.org> References: <1468404004-5085-1-git-send-email-mgorman@techsingularity.net> <1468404004-5085-4-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468404004-5085-4-git-send-email-mgorman@techsingularity.net> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Linux-MM , Minchan Kim , LKML On Wed, Jul 13, 2016 at 11:00:03AM +0100, Mel Gorman wrote: > From: Minchan Kim > > Note from Mel: This may optionally be considered a fix to the mmotm patch > mm-page_alloc-consider-dirtyable-memory-in-terms-of-nodes.patch > but if so, please preserve credit for Minchan. > > When I tested vmscale in mmtest in 32bit, I found the benchmark was slow > down 0.5 times. > > base node > 1 global-1 > User 12.98 16.04 > System 147.61 166.42 > Elapsed 26.48 38.08 > > With vmstat, I found IO wait avg is much increased compared to base. > > The reason was highmem_dirtyable_memory accumulates free pages and > highmem_file_pages from HIGHMEM to MOVABLE zones which was wrong. With > that, dirth_thresh in throtlle_vm_write is always 0 so that it calls > congestion_wait frequently if writeback starts. > > With this patch, it is much recovered. > > base node fi > 1 global-1 fix > User 12.98 16.04 13.78 > System 147.61 166.42 143.92 > Elapsed 26.48 38.08 29.64 > > Signed-off-by: Minchan Kim > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org