From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 50/64] drm/i915: Prepare i915_gem_active for annotations Date: Wed, 13 Jul 2016 16:58:50 +0100 Message-ID: <20160713155850.GJ6157@nuc-i3427.alporthouse.com> References: <1467880930-23082-1-git-send-email-chris@chris-wilson.co.uk> <1467880930-23082-50-git-send-email-chris@chris-wilson.co.uk> <578660D3.1090904@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C6546E2BA for ; Wed, 13 Jul 2016 15:58:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <578660D3.1090904@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMTMsIDIwMTYgYXQgMDQ6NDA6MDNQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMDcvMDcvMTYgMDk6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+SW4g dGhlIGZ1dHVyZSwgd2Ugd2lsbCB3YW50IHRvIGFkZCBhbm5vdGF0aW9ucyB0byB0aGUgaTkxNV9n ZW1fYWN0aXZlCj4gPnN0cnVjdC4gVGhlIEFQSSBpcyB0aHVzIGV4cGFuZGVkIHRvIGhpZGUgZGly ZWN0IGFjY2VzcyB0byB0aGUgY29udGVudHMKPiA+b2YgaTkxNV9nZW1fYWN0aXZlIGFuZCBtZWRp YXRlZCBpbnN0ZWFkIHRocm91Z2ggYSBudW1iZXIgb2YgaGVscGVycy4KPiA+Cj4gPlNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4tLS0KPiA+ ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPmluZGV4IDVmMzAyZmFmODZlNy4uOWMzNzFlODRiMWJi IDEwMDY0NAo+ID4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPisrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+QEAgLTEzNDksMjcgKzEzNDksMzAg QEAgaW50Cj4gPiAgaTkxNV9nZW1fb2JqZWN0X3dhaXRfcmVuZGVyaW5nKHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmosCj4gPiAgCQkJICAgICAgIGJvb2wgcmVhZG9ubHkpCj4gPiAgewo+ ID4rCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdDsKPiA+ICAJc3RydWN0IHJl c2VydmF0aW9uX29iamVjdCAqcmVzdjsKPiA+ICAJaW50IHJldCwgaTsKPiA+Cj4gPiAgCWlmIChy ZWFkb25seSkgewo+ID4tCQlpZiAob2JqLT5sYXN0X3dyaXRlLnJlcXVlc3QpIHsKPiA+LQkJCXJl dCA9IGk5MTVfd2FpdF9yZXF1ZXN0KG9iai0+bGFzdF93cml0ZS5yZXF1ZXN0KTsKPiA+KwkJcmVx dWVzdCA9IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKCZvYmotPmxhc3Rfd3JpdGUpOwo+IAo+IFdoeSBu b3QgZ2V0X3JlcXVlc3Qgc2luY2UgeW91IGhhdmUgZ2V0X2VuZ2luZT8gT3IgbGF0ZXIgdGhlcmUg d2lsbAo+IGJlIGdldF9yZXF1ZXN0IHdpdGggZGlmZmVyZW50IHNlbWFudGljcz8KCkl0IHdhc24n dCBtZWFudCB0byBiZSBhZGRpbmcgdGhlIHJlZmVyZW5jZS4uLgoKPiA+QEAgLTE0MjgsMjAgKzE0 MzEsMjAgQEAgaTkxNV9nZW1fb2JqZWN0X3dhaXRfcmVuZGVyaW5nX19ub25ibG9ja2luZyhzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ID4gIAlpZiAocmVhZG9ubHkpIHsKPiA+ICAJ CXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+ID4KPiA+LQkJcmVxID0gb2JqLT5s YXN0X3dyaXRlLnJlcXVlc3Q7Cj4gPisJCXJlcSA9IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKCZvYmot Pmxhc3Rfd3JpdGUpOwo+ID4gIAkJaWYgKHJlcSA9PSBOVUxMKQo+ID4gIAkJCXJldHVybiAwOwo+ ID4KPiA+LQkJcmVxdWVzdHNbbisrXSA9IGk5MTVfZ2VtX3JlcXVlc3RfZ2V0KHJlcSk7Cj4gPisJ CXJlcXVlc3RzW24rK10gPSByZXE7Cj4gCj4gSXQgdXNlZCB0byB0YWtlIGEgcmVmZXJlbmNlIGFu ZCBub3cgaXQgZG9lc24ndC4KCmFuZCB0aGlzIHNob3VsZCBzdGlsbCB0YWtlIHRoZSByZWZlcmVu Y2UuLi4KVGhpcyBwYXRjaCB3YXNuJ3QgbWVhbnQgdG8gYmUgbWFraW5nIHN1Y2ggY2hhbmdlcywg b25seSB0cmFuc2xhdGluZwpiZXR3ZWVuIGZ1bmN0aW9ucy4KCj4gPiAgCX0gZWxzZSB7Cj4gPiAg CQlmb3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1fRU5HSU5FUzsgaSsrKSB7Cj4gPiAgCQkJc3RydWN0 IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXE7Cj4gPgo+ID4tCQkJcmVxID0gb2JqLT5sYXN0X3Jl YWRbaV0ucmVxdWVzdDsKPiA+KwkJCXJlcSA9IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKCZvYmotPmxh c3RfcmVhZFtpXSk7Cj4gPiAgCQkJaWYgKHJlcSA9PSBOVUxMKQo+ID4gIAkJCQljb250aW51ZTsK PiA+Cj4gPi0JCQlyZXF1ZXN0c1tuKytdID0gaTkxNV9nZW1fcmVxdWVzdF9nZXQocmVxKTsKPiA+ KwkJCXJlcXVlc3RzW24rK10gPSByZXE7Cj4gPiAgCQl9Cj4gPiAgCX0KPiA+Cj4gPkBAIC0yMzgz LDI1ICsyMzg2LDI3IEBAIHZvaWQgaTkxNV92bWFfbW92ZV90b19hY3RpdmUoc3RydWN0IGk5MTVf dm1hICp2bWEsCj4gPiAgc3RhdGljIHZvaWQKPiA+ICBpOTE1X2dlbV9vYmplY3RfcmV0aXJlX193 cml0ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ID4gIHsKPiA+LQlHRU1fQlVH X09OKCFvYmotPmxhc3Rfd3JpdGUucmVxdWVzdCk7Cj4gPi0JR0VNX0JVR19PTighKG9iai0+YWN0 aXZlICYgaW50ZWxfZW5naW5lX2ZsYWcob2JqLT5sYXN0X3dyaXRlLnJlcXVlc3QtPmVuZ2luZSkp KTsKPiA+KwlHRU1fQlVHX09OKCFfX2k5MTVfZ2VtX2FjdGl2ZV9pc19idXN5KCZvYmotPmxhc3Rf d3JpdGUpKTsKPiA+KwlHRU1fQlVHX09OKCEob2JqLT5hY3RpdmUgJiBpbnRlbF9lbmdpbmVfZmxh ZyhpOTE1X2dlbV9hY3RpdmVfZ2V0X2VuZ2luZSgmb2JqLT5sYXN0X3dyaXRlKSkpKTsKPiA+Cj4g Pi0JaTkxNV9nZW1fcmVxdWVzdF9hc3NpZ24oJm9iai0+bGFzdF93cml0ZS5yZXF1ZXN0LCBOVUxM KTsKPiA+KwlpOTE1X2dlbV9hY3RpdmVfc2V0KCZvYmotPmxhc3Rfd3JpdGUsIE5VTEwpOwo+IAo+ IEFoYSEKCkRyYXQuIERpZG4ndCB0aGluayBJIGRpZCB0aGF0Li4uCgpPaCB3ZWxsLCBubyBleGN1 c2VzIG5vdyBidXQgdG8gZ28gYmFjayBpbiB0aW1lIGFuZCBtYWtlIHRoZSBjaGFuZ2UKZWFybGll ci4gSXQgZG9lcyBnZXQgcmVtb3ZlZCBldmVudHVhbGx5IQoKPiA+QEAgLTI4MjIsMjAgKzI4Mjcs MjEgQEAgaTkxNV9nZW1fd2FpdF9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpk YXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gPiAgCWk5MTVfZ2VtX29iamVjdF9wdXQob2Jq KTsKPiA+Cj4gPiAgCWZvciAoaSA9IDA7IGkgPCBJOTE1X05VTV9FTkdJTkVTOyBpKyspIHsKPiA+ LQkJaWYgKCFvYmotPmxhc3RfcmVhZFtpXS5yZXF1ZXN0KQo+ID4tCQkJY29udGludWU7Cj4gPisJ CXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxOwo+ID4KPiA+LQkJcmVxW24rK10gPSBp OTE1X2dlbV9yZXF1ZXN0X2dldChvYmotPmxhc3RfcmVhZFtpXS5yZXF1ZXN0KTsKPiA+KwkJcmVx ID0gaTkxNV9nZW1fYWN0aXZlX2dldCgmb2JqLT5sYXN0X3JlYWRbaV0pOwo+IAo+IE9oIHJpZ2h0 IHRoZXJlIGlzIGEgZ2V0IHJlcXVlc3Qgb25lLCB0aGlzIHRpbWUgcHJlc2VydmluZyB0aGUKPiBy ZWZlcmVuY2UgdGFraW5nIGJlaGF2aW91ci4KCll1cCwgeW91IHNwb3R0ZWQgbXkgbWl4IHVwIGVh cmxpZXIuCgo+ID4rLyoqCj4gPisgKiBpOTE1X2dlbV9hY3RpdmVfZ2V0IC0gcmV0dXJuIGEgcmVm ZXJlbmNlIHRvIHRoZSBhY3RpdmUgcmVxdWVzdAo+ID4rICogQGFjdGl2ZSAtIHRoZSBhY3RpdmUg dHJhY2tlcgo+ID4rICoKPiA+KyAqIGk5MTVfZ2VtX2FjdGl2ZV9nZXQoKSByZXR1cm5zIGEgcmVm ZXJlbmNlIHRvIHRoZSBhY3RpdmUgcmVxdWVzdCwgb3IgTlVMTAo+ID4rICogaWYgdGhlIGFjdGl2 ZSB0cmFja2VyIGlzIGlkbGUuIFRoZSBjYWxsZXIgbXVzdCBob2xkIHN0cnVjdF9tdXRleC4KPiA+ KyAqLwo+ID4rc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKgo+ID4r aTkxNV9nZW1fYWN0aXZlX2dldChjb25zdCBzdHJ1Y3QgaTkxNV9nZW1fYWN0aXZlICphY3RpdmUp Cj4gPit7Cj4gPisJc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0Owo+ID4rCj4g PisJcmVxdWVzdCA9IGk5MTVfZ2VtX2FjdGl2ZV9wZWVrKGFjdGl2ZSk7Cj4gPisJaWYgKCFyZXF1 ZXN0IHx8IGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHJlcXVlc3QpKQo+IAo+IFRoZSBjaGVj ayBmb3IgcmVxdWVzdF9jb21wbGV0ZWQgZmVlbHMgbGlrZSBhIGhhY2sgLSB3aHkgaXQgaXMgbmVl ZGVkPwoKQmVjYXVzZSByZXRpcmVtZW50IGlzIGxhenkgYW5kIHRoZSBHUFUgcnVucyBhc3luY2hy b25vdXNseS4gV2Ugd2FudCB0bwp3aGlsc3QgYnVpbGRpbmcgYW4gZXhlY2J1ZiBjaGVjayB3aGV0 aGVyIG9yIG5vdCB0aGUgd2FpdCBpcyByZXF1aXJlZC4gSWYKd2UgZGV0ZWN0IGEgd2FpdCB3ZSBo YXZlIHRvIGJhY2tvdXQgb2YgYW4gYXRvbWljIHNlY3Rpb24gaW5zaWRlIGV4ZWNidWYuCldoaWxz dCBleGVjYnVmIGlzIG1vcmUgZGVtYW5kaW5nLCB0aGUgc2hvcnRjaXJjdWl0IGFwcGxpZXMgZXF1 YWxseSBpbgptYW55IHBsYWNlcy4gVGhpcyBiZWNvbWVzIGVzcGVjaWFsbHkgYXBwYXJlbnQgd2hl biBsb29raW5nIGF0IHRoZQpyZXF1ZXN0IGxvY2tsZXNzbHksIGFuZCBJIHdhbnRlZCB0byBrZWVw IHRoaXMgcGF0aCBlcXVpdmFsZW50LgogCj4gPisvKioKPiA+KyAqIGk5MTVfZ2VtX2FjdGl2ZV9y ZXRpcmUgLSB3YWl0cyB1bnRpbCB0aGUgcmVxdWVzdCBpcyByZXRpcmVkCj4gPisgKiBAYWN0aXZl IC0gdGhlIGFjdGl2ZSByZXF1ZXN0IG9uIHdoaWNoIHRvIHdhaXQKPiA+KyAqCj4gPisgKiBVbmxp a2UgaTkxNV9nZW1fYWN0aXZlX2VhaXQoKSwgdGhpcyBpOTE1X2dlbV9hY3RpdmVfcmV0aXJlKCkg d2lsbAo+IAo+IHMvZWFpdC93YWl0Lwo+IAo+ID4rICogbWFrZSBzdXJlIHRoZSByZXF1ZXN0IGlz IHJldGlyZWQgYmVmb3JlIHJldHVybmluZy4KPiA+KyAqLwo+ID4rc3RhdGljIGlubGluZSBpbnQg X19tdXN0X2NoZWNrCj4gPitpOTE1X2dlbV9hY3RpdmVfcmV0aXJlKGNvbnN0IHN0cnVjdCBpOTE1 X2dlbV9hY3RpdmUgKmFjdGl2ZSkKPiA+K3sKPiA+KwlyZXR1cm4gaTkxNV9nZW1fYWN0aXZlX3dh aXQoYWN0aXZlKTsKPiA+K30KPiAKPiBCdXQgaG93IGRvZXMgaXQgZW5zdXJlIGFueXRoaW5nIGRp ZmZlcmVudCB0aGFuIGk5MTVfZ2VtX2FjdGl2ZV93YWl0Cj4gd2hlbiBpdCBjYWxscyB0aGUgdmVy eSBmdW5jdGlvbj8gTWF5YmUgaW4gZnV0dXJlIHBhdGNoZXMgdGhlcmUgd2lsbAo+IGJlIGEgZGlm ZmVyZW5jZT8KClJpZ2h0LiBJdCBjaGFuZ2VzIGluIHRoZSBmdXR1cmUsIGF0IHRoZSBtb21lbnQg aXQgaXMganVzdCB0cnlpbmcgdG8KaWxsdXN0cmF0ZSB0aGUgc2VtYW50aWMgZGlmZmVyZW5jZSAt IGluIHNvbWUgcGxhY2VzIHRoZSByZXRpcmVtZW50IGlzCnJlcXVpcmVkLCBidXQgb25seSBvZiB0 aGlzIGFjdGl2ZSB0cmFja2VyLCBpbiBvdGhlcnMgd2UgbmVlZCB0byByZXRpcmUKYWxsIHJlcXVl c3RzIHVwIHRvIHRoaXMgcG9pbnQsIG90aGVycyBzaW1wbHkgbmVlZCB0byBrbm93IHRoZSByZXF1 ZXN0IGlzCnBhc3NlZC4gCi1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3Vy Y2UgVGVjaG5vbG9neSBDZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==