From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Sean Paul <seanpaul@chromium.org>,
Zach Reizner <zachr@google.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH v3] drm/vgem: Attach sw fences to exported vGEM dma-buf (ioctl)
Date: Thu, 14 Jul 2016 16:36:37 +0200 [thread overview]
Message-ID: <20160714143637.GF17101@phenom.ffwll.local> (raw)
In-Reply-To: <20160714133954.GC22043@nuc-i3427.alporthouse.com>
On Thu, Jul 14, 2016 at 02:39:54PM +0100, Chris Wilson wrote:
> On Thu, Jul 14, 2016 at 02:23:04PM +0100, Chris Wilson wrote:
> > The biggest reason I had against going the sw_sync only route was that
> > vgem should provide unprivileged fences and that through the bookkeeping
> > in vgem we can keep them safe, ensure that we don't leak random buffers
> > or fences. (And I need a source of foriegn dma-buf with implicit fence
> > tracking with which I can try and break the driver.)
>
> And for testing passing around content + fences is more useful than
> passing fences alone.
Yup, agreed. But having fences free-standing isn't a real issue since
their refcounted and the userspace parts (sync_file) will get cleaned up
on process exit latest. Ḯ'm not advocating for any behaviour change at
all, just for hiding these things in debugfs.
Or maybe we could add a special (tainting) module option to vgem.ko which
enables this interface? That would be even less work, can easily be
integrated into igt (just set that knob at runtime, done), and with a
stern enough warning in dmesg + tainting the point should be clear. Of
course that switch would be off by default. Thoughts?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-07-14 14:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:46 [PATCH v2] drm/vgem: Attach sw fences to exported vGEM dma-buf (ioctl) Chris Wilson
2016-07-12 16:13 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-07-13 18:57 ` [PATCH v2] " Chris Wilson
2016-07-13 20:29 ` Gustavo Padovan
2016-07-13 20:46 ` Chris Wilson
2016-07-14 7:04 ` [PATCH v3] " Chris Wilson
2016-07-14 8:12 ` Daniel Vetter
2016-07-14 9:59 ` Chris Wilson
2016-07-14 10:11 ` Chris Wilson
2016-07-14 12:15 ` [Intel-gfx] " Chris Wilson
2016-07-14 12:40 ` Daniel Vetter
2016-07-14 13:23 ` Chris Wilson
2016-07-14 13:39 ` Chris Wilson
2016-07-14 14:36 ` Daniel Vetter [this message]
2016-07-14 15:24 ` Chris Wilson
2016-07-15 7:08 ` [Intel-gfx] " Daniel Vetter
2016-07-14 14:33 ` Daniel Vetter
2016-07-15 8:31 ` [PATCH v4] " Chris Wilson
2016-07-18 6:34 ` Daniel Vetter
2016-07-15 9:15 ` ✗ Ro.CI.BAT: failure for drm/vgem: Attach sw fences to exported vGEM dma-buf (ioctl) (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714143637.GF17101@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
--cc=zachr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.