From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbcGOStG (ORCPT ); Fri, 15 Jul 2016 14:49:06 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51390 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbcGOStD (ORCPT ); Fri, 15 Jul 2016 14:49:03 -0400 Date: Fri, 15 Jul 2016 11:49:02 -0700 (PDT) Message-Id: <20160715.114902.1149848183971707484.davem@davemloft.net> To: amir.jer.levy@intel.com Cc: andreas.noever@gmail.com, gregkh@linuxfoundation.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thunderbolt-linux@intel.com, mika.westerberg@intel.com, tomas.winkler@intel.com Subject: Re: [PATCH v3 2/8] thunderbolt: Updating device IDs From: David Miller In-Reply-To: <1468495702-7467-3-git-send-email-amir.jer.levy@intel.com> References: <1468495702-7467-1-git-send-email-amir.jer.levy@intel.com> <1468495702-7467-3-git-send-email-amir.jer.levy@intel.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jul 2016 11:49:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amir Levy Date: Thu, 14 Jul 2016 14:28:16 +0300 > Adding the new Thunderbolt(TM) device IDs to the list. > > Signed-off-by: Amir Levy Unless these PCI-IDs, all of them, are going to be used in multiple spots in the kernel, it is not appropriate to add them here. They belong as private macros in the drivers themselves, instead.