From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932151AbcGOHVE (ORCPT ); Fri, 15 Jul 2016 03:21:04 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33884 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbcGOHVA (ORCPT ); Fri, 15 Jul 2016 03:21:00 -0400 Date: Fri, 15 Jul 2016 15:13:09 +0800 From: Peter Chen To: Rajesh Bhagat Cc: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Message-ID: <20160715071309.GF817@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > + > > > +err_clks: > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation. > > > > We do have multiple clocks, but currently one is integrated in code. Hence created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Date: Fri, 15 Jul 2016 15:13:09 +0800 Message-ID: <20160715071309.GF817@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rajesh Bhagat Cc: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > + > > > +err_clks: > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation. > > > > We do have multiple clocks, but currently one is integrated in code. Hence created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: hzpeterchen@gmail.com (Peter Chen) Date: Fri, 15 Jul 2016 15:13:09 +0800 Subject: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver In-Reply-To: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> Message-ID: <20160715071309.GF817@shlinux2> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > + > > > +err_clks: > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation. > > > > We do have multiple clocks, but currently one is integrated in code. Hence created > the APIs for future use. If you could not integrate one more clocks, I suggest not creating dedicated API until you need in future. -- Best Regards, Peter Chen