From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932586AbcGOKue (ORCPT ); Fri, 15 Jul 2016 06:50:34 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34490 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932493AbcGOKub (ORCPT ); Fri, 15 Jul 2016 06:50:31 -0400 Date: Fri, 15 Jul 2016 12:50:34 +0200 From: Johan Hovold To: Sergei Shtylyov Cc: Mathieu OTHACEHE , johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/36] usb: serial: ti_usb_3410_5052: Use inline functions rather than macro Message-ID: <20160715105034.GC8809@localhost> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> <1463042948-12205-5-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 03:00:39PM +0300, Sergei Shtylyov wrote: > Hello. > > On 5/12/2016 11:48 AM, Mathieu OTHACEHE wrote: > > > Inline functions are preferable to macros resembling functions. > > > > Signed-off-by: Mathieu OTHACEHE > > --- > > drivers/usb/serial/ti_usb_3410_5052.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c > > index 6002e8b..2fc3ea1 100644 > > --- a/drivers/usb/serial/ti_usb_3410_5052.c > > +++ b/drivers/usb/serial/ti_usb_3410_5052.c > > @@ -248,8 +248,16 @@ struct ti_interrupt { > > } __packed; > > > > /* Interrupt codes */ > > -#define TI_GET_PORT_FROM_CODE(c) (((c) >> 4) - 3) > > -#define TI_GET_FUNC_FROM_CODE(c) ((c) & 0x0f) > > +static inline int ti_get_port_from_code(unsigned char code) > > +{ > > + return (code >> 4) - 3; > > +} > > + > > +static inline int ti_get_func_from_code(unsigned char code) > > +{ > > + return code & 0x0f; > > +} > > + > > We don't specify *inline* in the .c files (only in .h), letting gcc figure > it out. Indeed. I dropped the inline keywords and also moved the functions above the interrupt-in completion handler, which is the only place they are used. Thanks, Johan