From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932769AbcGOLgb (ORCPT ); Fri, 15 Jul 2016 07:36:31 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35710 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932590AbcGOLga (ORCPT ); Fri, 15 Jul 2016 07:36:30 -0400 Date: Fri, 15 Jul 2016 13:36:32 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Message-ID: <20160715113632.GK8809@localhost> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> <1463042948-12205-19-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463042948-12205-19-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote: > Remove useless ti_device pointer, and change addr to u32. > Move function upper to avoid function prototyping. That's just noise. Having an occasional prototype is just fine. You may want to consider reordering functions for the first submission, but no need to move things around after that. > Also change size variable in function from int to size_t. Combining changes with moving code, makes it harder to review for no good reason. Thanks, Johan